Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

Issue 2019963002: Remove get from CrossThreadPersistent to avoid accidental use Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CrossThreadHolder_h 5 #ifndef CrossThreadHolder_h
6 #define CrossThreadHolder_h 6 #define CrossThreadHolder_h
7 7
8 #include "core/dom/ActiveDOMObject.h" 8 #include "core/dom/ActiveDOMObject.h"
9 #include "core/dom/CrossThreadTask.h" 9 #include "core/dom/CrossThreadTask.h"
10 #include "core/dom/ExecutionContext.h" 10 #include "core/dom/ExecutionContext.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 // destructed (possibly on the calling thread or on the thread of 46 // destructed (possibly on the calling thread or on the thread of
47 // |executionContext|) when |executionContext| is stopped or 47 // |executionContext|) when |executionContext| is stopped or
48 // CrossThreadHolder is destructed. 48 // CrossThreadHolder is destructed.
49 void postTask(std::unique_ptr<WTF::Function<void(T*, ExecutionContext*), WTF ::CrossThreadAffinity>> task) 49 void postTask(std::unique_ptr<WTF::Function<void(T*, ExecutionContext*), WTF ::CrossThreadAffinity>> task)
50 { 50 {
51 MutexLocker locker(m_mutex->mutex()); 51 MutexLocker locker(m_mutex->mutex());
52 if (!m_bridge) { 52 if (!m_bridge) {
53 // The bridge has already disappeared. 53 // The bridge has already disappeared.
54 return; 54 return;
55 } 55 }
56 m_bridge->getExecutionContext()->postTask(BLINK_FROM_HERE, createCrossTh readTask(&Bridge::runTask, wrapCrossThreadPersistent(m_bridge.get()), passed(std ::move(task)))); 56 m_bridge->getExecutionContext()->postTask(BLINK_FROM_HERE, createCrossTh readTask(&Bridge::runTask, wrapCrossThreadPersistent(m_bridge), passed(std::move (task))));
57 } 57 }
58 58
59 ~CrossThreadHolder() 59 ~CrossThreadHolder()
60 { 60 {
61 MutexLocker locker(m_mutex->mutex()); 61 MutexLocker locker(m_mutex->mutex());
62 clearInternal(); 62 clearInternal();
63 } 63 }
64 64
65 private: 65 private:
66 // Object graph: 66 // Object graph:
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 RefPtr<MutexWrapper> m_mutex; 168 RefPtr<MutexWrapper> m_mutex;
169 // |m_bridge| is protected by |m_mutex|. 169 // |m_bridge| is protected by |m_mutex|.
170 // |m_bridge| is cleared before the thread that allocated |*m_bridge| 170 // |m_bridge| is cleared before the thread that allocated |*m_bridge|
171 // is stopped. 171 // is stopped.
172 CrossThreadPersistent<Bridge> m_bridge; 172 CrossThreadPersistent<Bridge> m_bridge;
173 }; 173 };
174 174
175 } // namespace blink 175 } // namespace blink
176 176
177 #endif // CrossThreadHolder_h 177 #endif // CrossThreadHolder_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698