Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: tests/standalone/io/secure_server_client_certificate_test.dart

Issue 201993002: Fix SecureSocket tests to look up localhost only once, where possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove useless change to https_client_certificate_test.dart Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/secure_server_client_certificate_test.dart
diff --git a/tests/standalone/io/secure_server_client_certificate_test.dart b/tests/standalone/io/secure_server_client_certificate_test.dart
index a0bcb41b976fc781d277b40dd6079770c8cd261a..34de17d037fbe2e8f3b04e5577fbdc76cf893c86 100644
--- a/tests/standalone/io/secure_server_client_certificate_test.dart
+++ b/tests/standalone/io/secure_server_client_certificate_test.dart
@@ -7,18 +7,17 @@ import "dart:io";
import "package:async_helper/async_helper.dart";
import "package:expect/expect.dart";
-import "package:path/path.dart";
-const HOST_NAME = "localhost";
+InternetAddress HOST;
const CERTIFICATE = "localhost_cert";
Future testClientCertificate() {
var completer = new Completer();
- SecureServerSocket.bind(HOST_NAME,
+ SecureServerSocket.bind(HOST,
0,
CERTIFICATE,
requestClientCertificate: true).then((server) {
- var clientEndFuture = SecureSocket.connect(HOST_NAME,
+ var clientEndFuture = SecureSocket.connect(HOST,
server.port,
sendClientCertificate: true);
server.listen((serverEnd) {
@@ -43,11 +42,11 @@ Future testClientCertificate() {
Future testRequiredClientCertificate() {
var completer = new Completer();
- SecureServerSocket.bind(HOST_NAME,
+ SecureServerSocket.bind(HOST,
0,
CERTIFICATE,
requireClientCertificate: true).then((server) {
- var clientEndFuture = SecureSocket.connect(HOST_NAME,
+ var clientEndFuture = SecureSocket.connect(HOST,
server.port,
sendClientCertificate: true);
server.listen((serverEnd) {
@@ -77,7 +76,8 @@ void main() {
useBuiltinRoots: false);
asyncStart();
- testClientCertificate()
+ InternetAddress.lookup("localhost").then((hosts) => HOST = hosts.first)
+ .then((_) => testClientCertificate())
.then((_) => testRequiredClientCertificate())
.then((_) => asyncEnd());
}

Powered by Google App Engine
This is Rietveld 408576698