third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py - Issue 2019923002: Fix pylint unused-* warnings in webkitpy/tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py

Issue 2019923002: Fix pylint unused-* warnings in webkitpy/tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commitannouncer.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py

index 20f03f14c09e770f1f6d70571d8308bb07b0805b..44acc26aa242c3210c1e5530d415c4a5abe7ae84 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py

@@ -41,7 +41,7 @@ class AbstractLocalServerCommand(Command):

super(AbstractLocalServerCommand, self).__init__(options=options)

def _prepare_config(self, options, args, tool):

- return None

+ raise NotImplementedError('Subclasses should implement this method.')

qyearsley 2016/06/02 16:41:32 Currently, all subclasses implement this, so the b

def execute(self, options, args, tool):

config = self._prepare_config(options, args, tool)