Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2019903002: Turn ResourceLoaderSet into a part object. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn ResourceLoaderSet into a part object. The abstraction is really a derived HashSet, so make it a part object. (Change done in part to diagnose what appears to be a heap overwrite involving ResourceLoaderSet.) R= BUG=615673 Committed: https://crrev.com/3302313bb0d52bdfaa8796204fc3ced1c64a8197 Cr-Commit-Position: refs/heads/master@{#396657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -44 lines) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 5 chunks +20 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoaderSet.h View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoaderSet.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. Trying to perturb what seems to be a heap overwrite/mutation over ...
4 years, 6 months ago (2016-05-29 07:37:36 UTC) #3
haraken
LGTM
4 years, 6 months ago (2016-05-29 09:22:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019903002/1
4 years, 6 months ago (2016-05-29 10:00:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-29 10:52:58 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-29 10:54:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3302313bb0d52bdfaa8796204fc3ced1c64a8197
Cr-Commit-Position: refs/heads/master@{#396657}

Powered by Google App Engine
This is Rietveld 408576698