Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Side by Side Diff: components/translate/core/browser/translate_client.h

Issue 2019883002: [Cleanup] Added missing virtual dtor to base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_ 5 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_
6 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_ 6 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 15 matching lines...) Expand all
26 class TranslateDriver; 26 class TranslateDriver;
27 class TranslateInfoBarDelegate; 27 class TranslateInfoBarDelegate;
28 28
29 // A client interface that needs to be supplied to TranslateManager by the 29 // A client interface that needs to be supplied to TranslateManager by the
30 // embedder. 30 // embedder.
31 // 31 //
32 // Each client instance is associated with a given context within which a 32 // Each client instance is associated with a given context within which a
33 // TranslateManager is used (e.g. a single tab). 33 // TranslateManager is used (e.g. a single tab).
34 class TranslateClient { 34 class TranslateClient {
35 public: 35 public:
36 virtual ~TranslateClient() {};
37
36 // Gets the TranslateDriver associated with the client. 38 // Gets the TranslateDriver associated with the client.
37 virtual TranslateDriver* GetTranslateDriver() = 0; 39 virtual TranslateDriver* GetTranslateDriver() = 0;
38 40
39 // Returns the associated PrefService. 41 // Returns the associated PrefService.
40 virtual PrefService* GetPrefs() = 0; 42 virtual PrefService* GetPrefs() = 0;
41 43
42 // Returns the associated TranslatePrefs. 44 // Returns the associated TranslatePrefs.
43 virtual std::unique_ptr<TranslatePrefs> GetTranslatePrefs() = 0; 45 virtual std::unique_ptr<TranslatePrefs> GetTranslatePrefs() = 0;
44 46
45 // Returns the associated TranslateAcceptLanguages. 47 // Returns the associated TranslateAcceptLanguages.
(...skipping 21 matching lines...) Expand all
67 69
68 // Presents |report_url|, a URL containing information relating to reporting 70 // Presents |report_url|, a URL containing information relating to reporting
69 // a language detection error, to the user to allow them to report language 71 // a language detection error, to the user to allow them to report language
70 // detection errors as desired. 72 // detection errors as desired.
71 virtual void ShowReportLanguageDetectionErrorUI(const GURL& report_url) = 0; 73 virtual void ShowReportLanguageDetectionErrorUI(const GURL& report_url) = 0;
72 }; 74 };
73 75
74 } // namespace translate 76 } // namespace translate
75 77
76 #endif // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_ 78 #endif // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698