Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

Issue 2019853002: bluetooth: Use WebBluetoothDeviceId instead of string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-uuid-typemap
Patch Set: Fix build Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
diff --git a/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom b/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
index 279384e66a5eeb09df240ddd8e9f99d50dcfe23d..98a6ef449e5a885c5abead0163884184746cd075 100644
--- a/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
+++ b/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom
@@ -4,6 +4,7 @@
module blink.mojom;
+import "components/web_bluetooth/public/interfaces/web_bluetooth_device_id.mojom";
import "device/bluetooth/public/interfaces/bluetooth_uuid.mojom";
// Errors that can occur during Web Bluetooth execution, which are transformed
@@ -91,7 +92,7 @@ enum WebBluetoothGATTQueryQuantity {
};
struct WebBluetoothDevice {
- string id;
+ web_bluetooth.mojom.WebBluetoothDeviceId id;
string name;
array<string> uuids;
};
@@ -122,18 +123,18 @@ interface WebBluetoothService {
// connection to the device didn't exist already. If a GATT connection existed
// already then this function increases the ref count to keep that connection
// alive.
- RemoteServerConnect(string device_id) => (WebBluetoothError error);
+ RemoteServerConnect(web_bluetooth.mojom.WebBluetoothDeviceId device_id) => (WebBluetoothError error);
// If a GATT connection exists for Device with |device_id| then decreases
// the ref count for that connection.
- RemoteServerDisconnect(string device_id);
+ RemoteServerDisconnect(web_bluetooth.mojom.WebBluetoothDeviceId device_id);
// If |services_uuid| is present, returns services with |services_uuid|.
// Otherwise returns all non-blacklisted services.
// If |quantity| == WebBluetoothGATTQueryQuantity::SINGLE, only one
// service will be returned.
RemoteServerGetPrimaryServices(
- string device_id,
+ web_bluetooth.mojom.WebBluetoothDeviceId device_id,
WebBluetoothGATTQueryQuantity quantity,
device.mojom.BluetoothUUID? services_uuid) => (
WebBluetoothError error,
@@ -184,5 +185,5 @@ interface WebBluetoothService {
interface WebBluetoothServiceClient {
RemoteCharacteristicValueChanged(string characteristic_instance_id,
array<uint8> value);
- GattServerDisconnected(string device_id);
+ GattServerDisconnected(web_bluetooth.mojom.WebBluetoothDeviceId device_id);
};

Powered by Google App Engine
This is Rietveld 408576698