Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: content/browser/bluetooth/web_bluetooth_service_impl.h

Issue 2019853002: bluetooth: Use WebBluetoothDeviceId instead of string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-uuid-typemap
Patch Set: Fix build Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/web_bluetooth_service_impl.h
diff --git a/content/browser/bluetooth/web_bluetooth_service_impl.h b/content/browser/bluetooth/web_bluetooth_service_impl.h
index 4c07543c96ede611c9b9e2ece14397476a9eafa2..3075b5bbb2adde8514c58587d6e90a0ad9665bb5 100644
--- a/content/browser/bluetooth/web_bluetooth_service_impl.h
+++ b/content/browser/bluetooth/web_bluetooth_service_impl.h
@@ -97,13 +97,14 @@ class WebBluetoothServiceImpl : public blink::mojom::WebBluetoothService,
void RequestDevice(blink::mojom::WebBluetoothRequestDeviceOptionsPtr options,
const RequestDeviceCallback& callback) override;
void RemoteServerConnect(
- const mojo::String& device_id,
+ const web_bluetooth::WebBluetoothDeviceId& device_id,
const RemoteServerConnectCallback& callback) override;
- void RemoteServerDisconnect(const mojo::String& device_id) override;
+ void RemoteServerDisconnect(
+ const web_bluetooth::WebBluetoothDeviceId& device_id) override;
void RemoteServerGetPrimaryServices(
- const mojo::String& device_id,
+ const web_bluetooth::WebBluetoothDeviceId& device_id,
blink::mojom::WebBluetoothGATTQueryQuantity quantity,
- const base::Optional<device::BluetoothUUID>& services_uuid,
+ const base::Optional<device::BluetoothUUID>& service_uuid,
const RemoteServerGetPrimaryServicesCallback& callback) override;
void RemoteServiceGetCharacteristics(
const mojo::String& service_instance_id,
@@ -132,7 +133,7 @@ class WebBluetoothServiceImpl : public blink::mojom::WebBluetoothService,
// Should only be run after the services have been discovered for
// |device_address|.
void RemoteServerGetPrimaryServicesImpl(
- const mojo::String& device_id,
+ const web_bluetooth::WebBluetoothDeviceId& device_id,
blink::mojom::WebBluetoothGATTQueryQuantity quantity,
const base::Optional<device::BluetoothUUID>& services_uuid,
const RemoteServerGetPrimaryServicesCallback& callback,
@@ -148,12 +149,11 @@ class WebBluetoothServiceImpl : public blink::mojom::WebBluetoothService,
// Callbacks for BluetoothDevice::CreateGattConnection.
void OnCreateGATTConnectionSuccess(
- const std::string& device_id,
+ const web_bluetooth::WebBluetoothDeviceId& device_id,
base::TimeTicks start_time,
const RemoteServerConnectCallback& callback,
std::unique_ptr<device::BluetoothGattConnection> connection);
void OnCreateGATTConnectionFailed(
- const std::string& device_id,
base::TimeTicks start_time,
const RemoteServerConnectCallback& callback,
device::BluetoothDevice::ConnectErrorCode error_code);
@@ -195,7 +195,8 @@ class WebBluetoothServiceImpl : public blink::mojom::WebBluetoothService,
// Queries the platform cache for a Device with |device_id| for |origin|.
// Fills in the |outcome| field and the |device| field if successful.
- CacheQueryResult QueryCacheForDevice(const std::string& device_id);
+ CacheQueryResult QueryCacheForDevice(
+ const web_bluetooth::WebBluetoothDeviceId& device_id);
// Queries the platform cache for a Service with |service_instance_id|. Fills
// in the |outcome| field, and |device| and |service| fields if successful.

Powered by Google App Engine
This is Rietveld 408576698