bluetooth: Use WebBluetoothDeviceId instead of string

third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module blink.mojom;
 
 import "device/bluetooth/public/interfaces/bluetooth_uuid.mojom";
+import "content/common/bluetooth/bluetooth_device_id.mojom";
 
 // Errors that can occur during Web Bluetooth execution, which are transformed
 // to a DOMException in Source/modules/bluetooth/BluetoothError.cpp.
 //
 // These errors all produce constant message strings. If a particular message
 // needs a dynamic component, we should add a separate enum so type-checking the
 // IPC ensures the dynamic component is passed.
 enum WebBluetoothError {
   SUCCESS,
   // AbortError:
@@ skipping 64 matching lines @@
 };
 
 // Indicates if the function will return a single or multiple
 // GATT objects.
 enum WebBluetoothGATTQueryQuantity {
   SINGLE,
   MULTIPLE
 };
 
 struct WebBluetoothDevice {
-  string id;
+  content.mojom.BluetoothDeviceId id;
   string name;
   array<string> uuids;
 };
 
 struct WebBluetoothRemoteGATTService {
   string instance_id;
   string uuid;
 };
 
 struct WebBluetoothRemoteGATTCharacteristic {
   string instance_id;
   string uuid;
   uint32 properties;
 };
 
 // TODO(ortuno): Define Bluetooth Service.

[Jeffrey Yasskin, 2016/06/03 17:22:05]

OT: I think this TODO is obsolete.

[ortuno, 2016/06/06 22:23:00]

http://crrev.com/2041143002 :)

 // https://crbug.com/508771
 
 // Web Bluetooth Interface that Blink can use to perform
 // Bluetooth GATT Operations on Bluetooth Devices.
 interface WebBluetoothService {
   // Sets the client for this WebBluetoothService. The service will notify the
   // client of device events e.g. when a Characteristic's value changes or when
   // a device disconnects.
   SetClient(associated WebBluetoothServiceClient client);
 
   RequestDevice(WebBluetoothRequestDeviceOptions options)
     => (WebBluetoothError error, WebBluetoothDevice? device);
 
   // Creates a GATT Connection to a Bluetooth Device with |device_id| if a
   // connection to the device didn't exist already. If a GATT connection existed
   // already then this function increases the ref count to keep that connection
   // alive.
-  RemoteServerConnect(string device_id) => (WebBluetoothError error);
+  RemoteServerConnect(content.mojom.BluetoothDeviceId device_id) => (WebBluetoothError error);

[Jeffrey Yasskin, 2016/06/03 17:22:05]

I wish we had 'using' declarations in mojo.

[ortuno, 2016/06/06 22:23:00]

Me too :(

 
   // If a GATT connection exists for Device with |device_id| then decreases
   // the ref count for that connection.
-  RemoteServerDisconnect(string device_id);
+  RemoteServerDisconnect(content.mojom.BluetoothDeviceId device_id);
 
   // Returns the first GATT Service with |service_uuid| of a Bluetooth Device
   // with |device_id|.
   RemoteServerGetPrimaryService(
-    string device_id,
+    content.mojom.BluetoothDeviceId device_id,
     device.mojom.BluetoothUUID service_uuid) => (
       WebBluetoothError error,
       WebBluetoothRemoteGATTService? service);
 
   // Returns the Characteristics of a GATT Service with |service_instance_id|.
   // If |quantity| == WebBluetoothGATTQueryQuantity::SINGLE, only one
   // characteristic will be returned.
   RemoteServiceGetCharacteristics(
     string service_instance_id,
     WebBluetoothGATTQueryQuantity quantity,
@@ skipping 29 matching lines @@
   RemoteCharacteristicStopNotifications(
     string characteristic_instance_id) => ();
 };
 
 // Classes should implement this interface and pass an associated pointer
 // bound to them to the WebBluetoothService by using SetClient. Classes
 // that do this will be notified of device events e.g. device disconnection.
 interface WebBluetoothServiceClient {
   RemoteCharacteristicValueChanged(string characteristic_instance_id,
                                    array<uint8> value);
-  GattServerDisconnected(string device_id);
+  GattServerDisconnected(content.mojom.BluetoothDeviceId device_id);
 };