bluetooth: Use WebBluetoothDeviceId instead of string

content/renderer/bluetooth/web_bluetooth_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/bluetooth/web_bluetooth_impl.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 29 matching lines @@
                  base::Unretained(this),
                  base::Passed(base::WrapUnique(callbacks))));
 }
 
 void WebBluetoothImpl::connect(
     const blink::WebString& device_id,
     blink::WebBluetoothDevice* device,
     blink::WebBluetoothRemoteGATTServerConnectCallbacks* callbacks) {
   // TODO(crbug.com/495270): After the Bluetooth Tree is implemented, there will
   // only be one object per device. But for now we replace the previous object.
   connected_devices_[device_id.utf8()] = device;

[Jeffrey Yasskin, 2016/06/03 17:22:05]

Could you convert connected_devices_ to store BluetoothDeviceIds too?

[ortuno, 2016/06/06 22:23:00]

Done.

 
   GetWebBluetoothService().RemoteServerConnect(
-      mojo::String::From(device_id),
+      BluetoothDeviceId(device_id.utf8()),
       base::Bind(&WebBluetoothImpl::OnConnectComplete, base::Unretained(this),
                  base::Passed(base::WrapUnique(callbacks))));
 }
 
 void WebBluetoothImpl::disconnect(const blink::WebString& device_id) {
   connected_devices_.erase(device_id.utf8());
 
   GetWebBluetoothService().RemoteServerDisconnect(
-      mojo::String::From(device_id));
+      BluetoothDeviceId(device_id.utf8()));
 }
 
 void WebBluetoothImpl::getPrimaryService(
     const blink::WebString& device_id,
     const blink::WebString& service_uuid,
     blink::WebBluetoothGetPrimaryServiceCallbacks* callbacks) {
   GetWebBluetoothService().RemoteServerGetPrimaryService(
-      mojo::String::From(device_id),
+      BluetoothDeviceId(device_id.utf8()),
       base::make_optional(device::BluetoothUUID(service_uuid.utf8())),
       base::Bind(&WebBluetoothImpl::OnGetPrimaryServiceComplete,
                  base::Unretained(this), device_id,
                  base::Passed(base::WrapUnique(callbacks))));
 }
 
 void WebBluetoothImpl::getCharacteristics(
     const blink::WebString& service_instance_id,
     blink::mojom::WebBluetoothGATTQueryQuantity quantity,
     const blink::WebString& characteristics_uuid,
@@ skipping 81 matching lines @@
 void WebBluetoothImpl::OnRequestDeviceComplete(
     std::unique_ptr<blink::WebBluetoothRequestDeviceCallbacks> callbacks,
     const blink::mojom::WebBluetoothError error,
     blink::mojom::WebBluetoothDevicePtr device) {
   if (error == blink::mojom::WebBluetoothError::SUCCESS) {
     blink::WebVector<blink::WebString> uuids(device->uuids.size());
     for (size_t i = 0; i < device->uuids.size(); ++i)
       uuids[i] = blink::WebString::fromUTF8(device->uuids[i]);
 
     callbacks->onSuccess(base::WrapUnique(new blink::WebBluetoothDeviceInit(
-        blink::WebString::fromUTF8(device->id),
+        blink::WebString::fromUTF8(device->id.str()),
         blink::WebString::fromUTF8(device->name), uuids)));
   } else {
     callbacks->onError(error);
   }
 }
 
-void WebBluetoothImpl::GattServerDisconnected(const mojo::String& device_id) {
-  auto device_iter = connected_devices_.find(device_id);
+void WebBluetoothImpl::GattServerDisconnected(
+    const BluetoothDeviceId& device_id) {
+  auto device_iter = connected_devices_.find(device_id.str());
   if (device_iter != connected_devices_.end()) {
     device_iter->second->dispatchGattServerDisconnected();
     connected_devices_.erase(device_iter);
   }
 }
 
 void WebBluetoothImpl::OnConnectComplete(
     std::unique_ptr<blink::WebBluetoothRemoteGATTServerConnectCallbacks>
         callbacks,
     blink::mojom::WebBluetoothError error) {
@@ skipping 98 matching lines @@
     // Create an associated interface ptr and pass it to the WebBluetoothService
     // so that it can send us events without us prompting.
     blink::mojom::WebBluetoothServiceClientAssociatedPtrInfo ptr_info;
     binding_.Bind(&ptr_info, web_bluetooth_service_.associated_group());
     web_bluetooth_service_->SetClient(std::move(ptr_info));
   }
   return *web_bluetooth_service_;
 }
 
 }  // namespace content