gpu/ipc/common/mailbox.mojom - Issue 2019833002: Implement StructTraits for various cc and gpu types

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gpu/ipc/common/mailbox.mojom

Issue 2019833002: Implement StructTraits for various cc and gpu types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix DEPS file Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module gpu.mojom;	5 module gpu.mojom;

6	6

7 [Native]	7 // See gpu/command_buffer/common/mailbox.h

8 struct Mailbox;	8 struct Mailbox {

	9 array<int8, 64> name;
	piman 2016/05/31 16:08:49 I'm not well versed in the mojo semantics - does t I'm not well versed in the mojo semantics - does this means that the reader will always expect 64 int8s, and that it will report failure if there aren't exactly 64? Ken Rockot(use gerrit already) 2016/05/31 17:19:48 Yes. Receiving anything but an array with exactly Show quoted text On 2016/05/31 at 16:08:49, piman OOO back 2016-5-31 wrote: > I'm not well versed in the mojo semantics - does this means that the reader will always expect 64 int8s, and that it will report failure if there aren't exactly 64? Yes. Receiving anything but an array with exactly 64 elements is equivalent to receiving a malformed message. As such the bindings layer will reject the message (i.e. never dispatch) and the message pipe will be closed.
	10 };

OLD	NEW

« no previous file with comments | « gpu/ipc/common/DEPS ('k') | gpu/ipc/common/mailbox.typemap » ('j') | gpu/ipc/common/mailbox_struct_traits.cc » ('J')