Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

Issue 2019783002: Add histograms for requests that were fetched successfully (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed sclittle, asvitkine comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
index 7b3220e0f8a96096e13d23e255054dafbd68c74a..b6b48582f999c615bfba2150835c2df328578d02 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
@@ -119,7 +119,7 @@ bool DataReductionProxyBypassProtocol::MaybeBypassProxyAndPrepareToRetry(
net::ProxyServer::SCHEME_HTTPS, request->proxy_server()));
data_reduction_proxy_type_info.proxy_servers.push_back(net::ProxyServer(
net::ProxyServer::SCHEME_HTTP, request->proxy_server()));
- data_reduction_proxy_type_info.is_fallback = false;
+ data_reduction_proxy_type_info.proxy_index = 0;
} else {
ReportResponseProxyServerStatusHistogram(RESPONSE_PROXY_SERVER_STATUS_DRP);
}
@@ -130,7 +130,7 @@ bool DataReductionProxyBypassProtocol::MaybeBypassProxyAndPrepareToRetry(
// At this point, the response is expected to have the data reduction proxy
// via header, so detect and report cases where the via header is missing.
DataReductionProxyBypassStats::DetectAndRecordMissingViaHeaderResponseCode(
- !data_reduction_proxy_type_info.is_fallback, response_headers);
+ data_reduction_proxy_type_info.proxy_index == 0, response_headers);
// GetDataReductionProxyBypassType will only log a net_log event if a bypass
// command was sent via the data reduction proxy headers
@@ -152,7 +152,7 @@ bool DataReductionProxyBypassProtocol::MaybeBypassProxyAndPrepareToRetry(
request->context()->proxy_service()->proxy_retry_info(), proxy_server,
NULL)) {
DataReductionProxyBypassStats::RecordDataReductionProxyBypassInfo(
- !data_reduction_proxy_type_info.is_fallback,
+ data_reduction_proxy_type_info.proxy_index == 0,
data_reduction_proxy_info->bypass_all, proxy_server, bypass_type);
}
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698