base/task_scheduler/scheduler_worker.cc - Issue 2019763002: TaskScheduler: Atomic operations in TaskTracker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/scheduler_worker.cc

Issue 2019763002: TaskScheduler: Atomic operations in TaskTracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR danakj #51 (add memory barriers) Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/task_scheduler/scheduler_worker.cc

diff --git a/base/task_scheduler/scheduler_worker.cc b/base/task_scheduler/scheduler_worker.cc

index fcbc28382fa071ce56e0190cc5f03f57a30cb1a9..5a2a7d6a92b96272e1d148edeaec2c4a1782b672 100644

--- a/base/task_scheduler/scheduler_worker.cc

+++ b/base/task_scheduler/scheduler_worker.cc

@@ -36,7 +36,7 @@ class SchedulerWorker::Thread : public PlatformThread::Delegate {

// A SchedulerWorker starts out waiting for work.

WaitForWork();

- while (!outer_->task_tracker_->shutdown_completed() &&

+ while (!outer_->task_tracker_->IsShutdownComplete() &&

!outer_->ShouldExitForTesting()) {

DCHECK(outer_);

// Get the sequence containing the next task to execute.

« no previous file with comments | « no previous file | base/task_scheduler/task_tracker.h » ('j') | no next file with comments »