Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2019753002: make unittest allocator align to 64 bytes. (Closed)

Created:
4 years, 6 months ago by fbarchard1
Modified:
4 years, 6 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

make unittest allocator align to 64 bytes. blur requires memory be aligned. change the unittest allocator to guarantee 64 byte alignment. re-enable blur any test that fails if memory is unaligned. TBR=harryjin@google.com BUG=libyuv:596, libyuv:594 TESTED=local build passes with row.h removed from tests. Committed: https://chromium.googlesource.com/libyuv/libyuv/+/b00d40160a5a5d78a014ebbbdc4ced728d0f9cc5

Patch Set 1 #

Patch Set 2 : "enable 16 byte alignment check #

Patch Set 3 : change default width to 128 #

Patch Set 4 : unittest default update #

Patch Set 5 : make align 64 memory #

Patch Set 6 : align pointer to 64 #

Patch Set 7 : fix 80 columns #

Patch Set 8 : remove commented code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M README.chromium View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M source/planar_functions.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -3 lines 0 comments Download
M source/row_win.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M unit_test/planar_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M unit_test/unit_test.h View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M unit_test/unit_test.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
fbarchard1
Committed patchset #8 (id:140001) manually as b00d40160a5a5d78a014ebbbdc4ced728d0f9cc5 (presubmit successful).
4 years, 6 months ago (2016-05-28 01:02:52 UTC) #5
harryjin
4 years, 6 months ago (2016-05-28 01:30:59 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698