Re-set referrer on issuing a validation request for a cached resource.

Re-set referrer on issuing a validation request for a cached resource.

If a cached resource needs to be revalidated, then supply the referrer
of the document making the request.

R=japhet@chromium.org
BUG=344335
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169392

[sof, 2014-03-17 16:11:43]

When you have a moment, please take a look.

[Nate Chapin, 2014-03-17 16:22:26]

LGTM

https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
File Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
Source/core/fetch/ResourceFetcher.cpp:783:
revalidatingRequest.clearHTTPReferrer();
This works, though I wonder...is there anything other than the url that we need
from the old ResourceRequest?

[sof, 2014-03-17 17:04:39]

Looks like the windows trybot runs into a timeout on the added test; will have
to look into.

https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
File Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
Source/core/fetch/ResourceFetcher.cpp:783:
revalidatingRequest.clearHTTPReferrer();
On 2014/03/17 16:22:26, Nate Chapin wrote:
> This works, though I wonder...is there anything other than the url that we
need
> from the old ResourceRequest?

If the resource is eligible for reuse, then presumably there will be headers you
do want to propagate along?

[sof, 2014-03-17 17:07:22]

On 2014/03/17 17:04:39, sof wrote:
> Looks like the windows trybot runs into a timeout on the added test; will have
> to look into.
> 
>
https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
> File Source/core/fetch/ResourceFetcher.cpp (right):
> 
>
https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
> Source/core/fetch/ResourceFetcher.cpp:783:
> revalidatingRequest.clearHTTPReferrer();
> On 2014/03/17 16:22:26, Nate Chapin wrote:
> > This works, though I wonder...is there anything other than the url that we
> need
> > from the old ResourceRequest?
> 
> If the resource is eligible for reuse, then presumably there will be headers
you
> do want to propagate along?

s/resource/resource request/

[Nate Chapin, 2014-03-17 17:12:14]

On 2014/03/17 17:07:22, sof wrote:
> On 2014/03/17 17:04:39, sof wrote:
> > Looks like the windows trybot runs into a timeout on the added test; will
have
> > to look into.
> > 
> >
>
https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
> > File Source/core/fetch/ResourceFetcher.cpp (right):
> > 
> >
>
https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
> > Source/core/fetch/ResourceFetcher.cpp:783:
> > revalidatingRequest.clearHTTPReferrer();
> > On 2014/03/17 16:22:26, Nate Chapin wrote:
> > > This works, though I wonder...is there anything other than the url that we
> > need
> > > from the old ResourceRequest?
> > 
> > If the resource is eligible for reuse, then presumably there will be headers
> you
> > do want to propagate along?
> 
> s/resource/resource request/

Presumably. I was just trying to think of a specific example and failing in my
early-morning haze :)

[sof, 2014-03-17 21:10:48]

On 2014/03/17 17:12:14, Nate Chapin wrote:
> On 2014/03/17 17:07:22, sof wrote:
> > On 2014/03/17 17:04:39, sof wrote:
> > > Looks like the windows trybot runs into a timeout on the added test; will
> have
> > > to look into.
> > > 
> > >
> >
>
https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
> > > File Source/core/fetch/ResourceFetcher.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/201973002/diff/1/Source/core/fetch/ResourceFe...
> > > Source/core/fetch/ResourceFetcher.cpp:783:
> > > revalidatingRequest.clearHTTPReferrer();
> > > On 2014/03/17 16:22:26, Nate Chapin wrote:
> > > > This works, though I wonder...is there anything other than the url that
we
> > > need
> > > > from the old ResourceRequest?
> > > 
> > > If the resource is eligible for reuse, then presumably there will be
headers
> > you
> > > do want to propagate along?
> > 
> > s/resource/resource request/
> 
> Presumably. I was just trying to think of a specific example and failing in my
> early-morning haze :)

:) Conditional headers extend a request, so it wouldn't quite work.

(The Windows test timeout issue has been sorted out, php there wanting header()s
to be emitted before the payload.)

[sof, 2014-03-17 21:11:11]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-03-17 21:11:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/201973002/20001

[commit-bot: I haz the power, 2014-03-17 21:21:26]

Change committed as 169392