third_party/WebKit/LayoutTests/media/broken-video.html - Issue 2019643002: Convert before-*, broken-* and constructors.html tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/broken-video.html

Issue 2019643002: Convert before-*, broken-* and constructors.html tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/before-load-member-access.html ('K') | « third_party/WebKit/LayoutTests/media/before-load-member-access-expected.txt ('k') | third_party/WebKit/LayoutTests/media/broken-video-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <video controls></video>	1 <!DOCTYPE HTML>

2 <p>Test that an invalid video file generates a MEDIA_ERR_SRC_NOT_SUPPORTED error and sets networkState to NETWORK_NO_SOURCE.</p>	2 <title>Test that an invalid video file generates a MEDIA_ERR_SRC_NOT_SUPPORTED e rror and sets networkState to NETWORK_NO_SOURCE.</title>

3 <script src=media-file.js></script>	3 <script src="media-file.js"></script>

4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	4 <script src="../resources/testharness.js"></script>

5 (Please avoid writing new tests using video-test.js) -->	5 <script src="../resources/testharnessreport.js"></script>

6 <script src=video-test.js></script>	6 <video></video>

7

8 <script>	7 <script>

	8 async_test(function(t) {

	9 var video = document.querySelector("video");
	fs 2016/05/27 08:10:48 Nit: Indentation Nit: Indentation Srirama 2016/05/27 10:57:48 Done. Show quoted text On 2016/05/27 08:10:48, fs wrote: > Nit: Indentation Done.
9 video.src = findMediaFile("video", "content/garbage");	10 video.src = findMediaFile("video", "content/garbage");

10 waitForEvent("error", function () {	11 video.onerror = t.step_func_done(function () {

11 testExpected("video.error", "[object MediaError]");	12 assert_equals(video.error.code, MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);
fs 2016/05/27 08:10:48 Not sure what this was intended to test, but we co Not sure what this was intended to test, but we could keep it and test toString() (like it does here) or the 'video.error instanceof MediaError' perhaps? Pick one =)	foolip 2016/05/27 08:22:15 Add assert_true(video.error instanceof MediaError) Add assert_true(video.error instanceof MediaError) as that was kind of tested (via the stringifier) in the original test. Srirama 2016/05/27 10:57:48 Done. Show quoted text On 2016/05/27 08:22:15, Philip Jägenstedt wrote: > Add assert_true(video.error instanceof MediaError) as that was kind of tested > (via the stringifier) in the original test. Done.
12 testExpected("video.error.code", MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED) ;	13 assert_equals(video.networkState, HTMLMediaElement.NETWORK_NO_SOURCE);

13 testExpected("video.networkState", HTMLMediaElement.NETWORK_NO_SOURCE);

14 endTest();

15 });	14 });

	15 });

16 </script>	16 </script>

OLD	NEW