content/browser/service_worker/service_worker_version.h - Issue 2019613003: ServiceWorker: Bypass SW when the script doesn't have fetch handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2019613003: ServiceWorker: Bypass SW when the script doesn't have fetch handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test for subresources and fix the nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc ('K') | « content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 3b64744ae0dbd94869c51f8109b8c088a36c4832..9b88f791b286971ad5e1ad1853fa8260df2dfe62 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -330,6 +330,8 @@ class CONTENT_EXPORT ServiceWorkerVersion

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerControlleeRequestHandlerTest,

ActivateWaitingVersion);

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerControlleeRequestHandlerTest,

+ FallbackWithNoFetchHandler);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, IdleTimeout);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, SetDevToolsAttached);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionTest, StaleUpdate_FreshWorker);