Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: third_party/WebKit/Source/platform/animation/CompositorTransformAnimationCurve.h

Issue 2019613002: Blink Compositor Animation: Make Animation and Curve methods non-virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix codereview issues. Add cc::TimingFunction::Type enum. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/animation/CompositorTransformAnimationCurve.h
diff --git a/third_party/WebKit/Source/platform/animation/CompositorTransformAnimationCurve.h b/third_party/WebKit/Source/platform/animation/CompositorTransformAnimationCurve.h
index 724fe1b1bd8e5dc9f195aea148ef79685f2c59a8..75a95400b817c5fc534257ede4788a7c4b560c03 100644
--- a/third_party/WebKit/Source/platform/animation/CompositorTransformAnimationCurve.h
+++ b/third_party/WebKit/Source/platform/animation/CompositorTransformAnimationCurve.h
@@ -28,17 +28,17 @@ public:
CompositorTransformAnimationCurve();
~CompositorTransformAnimationCurve() override;
- virtual void addLinearKeyframe(const CompositorTransformKeyframe&);
- virtual void addCubicBezierKeyframe(const CompositorTransformKeyframe&, CubicBezierTimingFunction::EaseType);
+ void addLinearKeyframe(const CompositorTransformKeyframe&);
+ void addCubicBezierKeyframe(const CompositorTransformKeyframe&, CubicBezierTimingFunction::EaseType);
// Adds the keyframe with a custom, bezier timing function. Note, it is
// assumed that x0 = y0, and x3 = y3 = 1.
- virtual void addCubicBezierKeyframe(const CompositorTransformKeyframe&, double x1, double y1, double x2, double y2);
- virtual void addStepsKeyframe(const CompositorTransformKeyframe&, int steps, StepsTimingFunction::StepPosition);
+ void addCubicBezierKeyframe(const CompositorTransformKeyframe&, double x1, double y1, double x2, double y2);
+ void addStepsKeyframe(const CompositorTransformKeyframe&, int steps, StepsTimingFunction::StepPosition);
- virtual void setLinearTimingFunction();
- virtual void setCubicBezierTimingFunction(CubicBezierTimingFunction::EaseType);
- virtual void setCubicBezierTimingFunction(double x1, double y1, double x2, double y2);
- virtual void setStepsTimingFunction(int numberOfSteps, StepsTimingFunction::StepPosition);
+ void setLinearTimingFunction();
+ void setCubicBezierTimingFunction(CubicBezierTimingFunction::EaseType);
+ void setCubicBezierTimingFunction(double x1, double y1, double x2, double y2);
+ void setStepsTimingFunction(int numberOfSteps, StepsTimingFunction::StepPosition);
// CompositorAnimationCurve implementation.
std::unique_ptr<cc::AnimationCurve> cloneToAnimationCurve() const override;
« no previous file with comments | « third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698