third_party/WebKit/Source/platform/animation/CompositorFilterAnimationCurve.h - Issue 2019613002: Blink Compositor Animation: Make Animation and Curve methods non-virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/animation/CompositorFilterAnimationCurve.h

Issue 2019613002: Blink Compositor Animation: Make Animation and Curve methods non-virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix codereview issues. Add cc::TimingFunction::Type enum. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/animation/CompositorAnimation.cpp ('k') | third_party/WebKit/Source/platform/animation/CompositorFloatAnimationCurve.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/animation/CompositorFilterAnimationCurve.h

diff --git a/third_party/WebKit/Source/platform/animation/CompositorFilterAnimationCurve.h b/third_party/WebKit/Source/platform/animation/CompositorFilterAnimationCurve.h

index ff9a71aebc9b2d87fd9e0701fce57310aa07ca77..e4d4be5220e9e7da0c4246b4b36c20b25e083592 100644

--- a/third_party/WebKit/Source/platform/animation/CompositorFilterAnimationCurve.h

+++ b/third_party/WebKit/Source/platform/animation/CompositorFilterAnimationCurve.h

@@ -28,17 +28,17 @@ public:

CompositorFilterAnimationCurve();

~CompositorFilterAnimationCurve() override;

- virtual void addLinearKeyframe(const CompositorFilterKeyframe&);

- virtual void addCubicBezierKeyframe(const CompositorFilterKeyframe&, CubicBezierTimingFunction::EaseType);

+ void addLinearKeyframe(const CompositorFilterKeyframe&);

+ void addCubicBezierKeyframe(const CompositorFilterKeyframe&, CubicBezierTimingFunction::EaseType);

// Adds the keyframe with a custom, bezier timing function. Note, it is

// assumed that x0 = y0, and x3 = y3 = 1.

- virtual void addCubicBezierKeyframe(const CompositorFilterKeyframe&, double x1, double y1, double x2, double y2);

- virtual void addStepsKeyframe(const CompositorFilterKeyframe&, int steps, StepsTimingFunction::StepPosition);

+ void addCubicBezierKeyframe(const CompositorFilterKeyframe&, double x1, double y1, double x2, double y2);

+ void addStepsKeyframe(const CompositorFilterKeyframe&, int steps, StepsTimingFunction::StepPosition);

- virtual void setLinearTimingFunction();

- virtual void setCubicBezierTimingFunction(CubicBezierTimingFunction::EaseType);

- virtual void setCubicBezierTimingFunction(double x1, double y1, double x2, double y2);

- virtual void setStepsTimingFunction(int numberOfSteps, StepsTimingFunction::StepPosition);

+ void setLinearTimingFunction();

+ void setCubicBezierTimingFunction(CubicBezierTimingFunction::EaseType);

+ void setCubicBezierTimingFunction(double x1, double y1, double x2, double y2);

+ void setStepsTimingFunction(int numberOfSteps, StepsTimingFunction::StepPosition);

// blink::CompositorAnimationCurve implementation.

std::unique_ptr<cc::AnimationCurve> cloneToAnimationCurve() const override;