cc/animation/timing_function.h - Issue 2019613002: Blink Compositor Animation: Make Animation and Curve methods non-virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/timing_function.h

Issue 2019613002: Blink Compositor Animation: Make Animation and Curve methods non-virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add the check if keframe 0 is linear. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/animation/keyframed_animation_curve.h ('k') | cc/animation/timing_function.cc » ('j') | third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/animation/timing_function.h

diff --git a/cc/animation/timing_function.h b/cc/animation/timing_function.h

index d1807f6f091c90a2cffd947d2f95c20541c1c195..ebe31fcfbba43c5192f1aa9e397a17e859ff278c 100644

--- a/cc/animation/timing_function.h

+++ b/cc/animation/timing_function.h

@@ -48,10 +48,17 @@ class CC_EXPORT CubicBezierTimingFunction : public TimingFunction {

void Range(float* min, float* max) const override;

std::unique_ptr<TimingFunction> Clone() const override;

+ EaseType ease_type() const { return ease_type_; }

protected:

- CubicBezierTimingFunction(double x1, double y1, double x2, double y2);

+ CubicBezierTimingFunction(EaseType ease_type,

+ double x1,

+ double y1,

+ double x2,

+ double y2);

gfx::CubicBezier bezier_;

+ EaseType ease_type_;

private:

DISALLOW_ASSIGN(CubicBezierTimingFunction);