third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h - Issue 2019613002: Blink Compositor Animation: Make Animation and Curve methods non-virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h

Issue 2019613002: Blink Compositor Animation: Make Animation and Curve methods non-virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rework it. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/animation/CompositorFloatAnimationCurve.cpp ('K') | « third_party/WebKit/Source/platform/animation/CompositorFloatAnimationCurve.cpp ('k') | third_party/WebKit/Source/platform/animation/CompositorTransformAnimationCurve.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h

diff --git a/third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h b/third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h

index f7baac07e12f41781acb47bcd8b7a10869aae271..42b1549ec275fb24b90fb6900a837471a239bbf4 100644

--- a/third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h

+++ b/third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h

@@ -29,11 +29,11 @@ public:

CompositorScrollOffsetAnimationCurve(cc::ScrollOffsetAnimationCurve*);

~CompositorScrollOffsetAnimationCurve() override;

- virtual void setInitialValue(FloatPoint);

- virtual FloatPoint getValue(double time) const;

- virtual double duration() const;

- virtual FloatPoint targetValue() const;

- virtual void updateTarget(double time, FloatPoint newTarget);

+ void setInitialValue(FloatPoint);

+ FloatPoint getValue(double time) const;

+ double duration() const;

+ FloatPoint targetValue() const;

+ void updateTarget(double time, FloatPoint newTarget);

// CompositorAnimationCurve implementation.

std::unique_ptr<cc::AnimationCurve> cloneToAnimationCurve() const override;