Remove unused PS generation code.

Remove unused PS generation code.

CFX_PSRenderer, IFX_PSOutput, CPSOutput, CPSPrinterDriver.

Also reland commit 2d63eaa.

Committed: https://pdfium.googlesource.com/pdfium/+/b0fcfad1412c2ddaf33c74fa4b854c3c1390a509

[Lei Zhang, 2016-05-27 06:59:04]

Description was changed from

==========
Remove unused PS generation code.

CFX_PSRenderer, IFX_PSOutput, CPSOutput, CPSPrinterDriver.
==========

to

==========
Remove unused PS generation code.

CFX_PSRenderer, IFX_PSOutput, CPSOutput, CPSPrinterDriver.

Also reland commit 2d63eaa.
==========

[Lei Zhang, 2016-05-27 18:17:37]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-05-27 18:27:57]

https://codereview.chromium.org/2019603002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h (right):

https://codereview.chromium.org/2019603002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h:33: // only one callers,
so the interface has been simplified, the values are hard
nit: only one caller.

https://codereview.chromium.org/2019603002/diff/20001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_jpeg.cpp (right):

https://codereview.chromium.org/2019603002/diff/20001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_jpeg.cpp:26: static void JpegScanSOI(const uint8_t*&
src_buf, uint32_t& src_size) {
wanna make this a **, particularly ironic since pass by ref isn't in C, and this
is in an extern C section.

[Lei Zhang, 2016-05-27 22:18:51]

https://codereview.chromium.org/2019603002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h (right):

https://codereview.chromium.org/2019603002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h:33: // only one callers,
so the interface has been simplified, the values are hard
On 2016/05/27 18:27:57, Tom Sepez wrote:
> nit: only one caller.

Done.

https://codereview.chromium.org/2019603002/diff/20001/core/fxcodec/codec/fx_c...
File core/fxcodec/codec/fx_codec_jpeg.cpp (right):

https://codereview.chromium.org/2019603002/diff/20001/core/fxcodec/codec/fx_c...
core/fxcodec/codec/fx_codec_jpeg.cpp:26: static void JpegScanSOI(const uint8_t*&
src_buf, uint32_t& src_size) {
On 2016/05/27 18:27:57, Tom Sepez wrote:
> wanna make this a **, particularly ironic since pass by ref isn't in C, and
this
> is in an extern C section.

Done.

[Lei Zhang, 2016-05-27 22:57:23]

And I don't understand what's wrong with the bots. :\

[Lei Zhang, 2016-05-27 23:24:30]

On 2016/05/27 22:57:23, Lei Zhang wrote:
> And I don't understand what's wrong with the bots. :\

Filed: https://bugs.chromium.org/p/chromium/issues/detail?id=615567

[Lei Zhang, 2016-05-28 06:32:48]

And I unwedged the trybots.

[Tom Sepez, 2016-05-31 19:10:58]

lgtm

[Lei Zhang, 2016-05-31 19:14:36]

+caryclark FYI.

I'll land this in a few hours. Let me know if there's any concerns.

[caryclark, 2016-05-31 19:50:45]

How did you determine that 

FX_BOOL ContinueDIBits(void* handle, IFX_Pause* pPause) override {	
   return FALSE;	
}	
void CancelDIBits(void* handle) override {}

in apple_int.h are unused?

[Lei Zhang, 2016-05-31 20:08:34]

On 2016/05/31 19:50:45, caryclark wrote:
> How did you determine that 
> 
> FX_BOOL ContinueDIBits(void* handle, IFX_Pause* pPause) override {	
>    return FALSE;	
> }	
> void CancelDIBits(void* handle) override {}
> 
> in apple_int.h are unused?

They override the default implementations in IFX_RenderDeviceDriver, which are
the same.

[Lei Zhang, 2016-06-07 00:43:27]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-06-07 00:43:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2019603002/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-07 00:43:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019603002/140001

[commit-bot: I haz the power, 2016-06-07 00:54:34]

Description was changed from

==========
Remove unused PS generation code.

CFX_PSRenderer, IFX_PSOutput, CPSOutput, CPSPrinterDriver.

Also reland commit 2d63eaa.
==========

to

==========
Remove unused PS generation code.

CFX_PSRenderer, IFX_PSOutput, CPSOutput, CPSPrinterDriver.

Also reland commit 2d63eaa.

Committed:
https://pdfium.googlesource.com/pdfium/+/b0fcfad1412c2ddaf33c74fa4b854c3c1390...
==========

[commit-bot: I haz the power, 2016-06-07 00:54:34]

Committed patchset #8 (id:140001) as
https://pdfium.googlesource.com/pdfium/+/b0fcfad1412c2ddaf33c74fa4b854c3c1390...