Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2019593003: chromite recipe: Add warm cache flag support. (Closed)

Created:
4 years, 6 months ago by dnj
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

chromite recipe: Add warm cache flag support. BUG=chromium:609886 TEST=expectations Committed: https://chromium.googlesource.com/chromium/tools/build/+/7ee232bf454d9c881e85f91b143cfad858c17ff5

Patch Set 1 #

Total comments: 1

Patch Set 2 : New flag name. #

Patch Set 3 : Better config option name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M scripts/slave/recipe_modules/chromite/api.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromite/config.py View 1 2 4 chunks +11 lines, -0 lines 0 comments Download
M scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_coverage.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_paladin.json View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dnj (Google)
PTAL
4 years, 6 months ago (2016-05-27 23:02:03 UTC) #2
dgarrett
LGTM, except for the option name change. https://codereview.chromium.org/2019593003/diff/1/scripts/slave/recipe_modules/chromite/api.py File scripts/slave/recipe_modules/chromite/api.py (right): https://codereview.chromium.org/2019593003/diff/1/scripts/slave/recipe_modules/chromite/api.py#newcode352 scripts/slave/recipe_modules/chromite/api.py:352: cbb_args.extend(['--buildbot-warm-cache-path', self.c.warm_cache_dir]) ...
4 years, 6 months ago (2016-05-27 23:13:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019593003/20001
4 years, 6 months ago (2016-06-08 18:16:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019593003/40001
4 years, 6 months ago (2016-06-08 18:18:51 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 18:22:49 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/7ee232bf454d9c881e85...

Powered by Google App Engine
This is Rietveld 408576698