Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: chrome/browser/media/media_stream_devices_controller.h

Issue 2019573002: Permissions: Allow control of individual requests in media permission infobars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/media_stream_devices_controller.h
diff --git a/chrome/browser/media/media_stream_devices_controller.h b/chrome/browser/media/media_stream_devices_controller.h
index 61f616b7ef4d75b9c3143010247beec30d638810..109e055018b8753abc870e392c1db6e3b163f211 100644
--- a/chrome/browser/media/media_stream_devices_controller.h
+++ b/chrome/browser/media/media_stream_devices_controller.h
@@ -50,6 +50,13 @@ class MediaStreamDevicesController : public PermissionBubbleRequest {
// on the permissions if they are in the ASK state.
void ForcePermissionDeniedTemporarily();
+ // Answers a permission request with (possibly) different values for
+ // |audio_accepted| and |video_accepted|. Intended for use from
+ // MediaStreamInfobarDelegateAndroid.
+ // TODO(tsergeant): Remove this by refactoring Android to use
+ // PermissionBubbleRequest instead of a custom infobar delegate.
+ void PermissionSplitResult(bool audio_accepted, bool video_accepted);
benwells 2016/06/05 23:53:05 Nit: Can you think of a better name?
tsergeant 2016/06/06 00:38:30 I've renamed to GroupedRequestFinished. Do you thi
benwells 2016/06/06 01:10:02 Yep, much better!
+
// PermissionBubbleRequest:
int GetIconId() const override;
base::string16 GetMessageTextFragment() const override;

Powered by Google App Engine
This is Rietveld 408576698