Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html

Issue 2019563002: MD Settings: implement "controlled by" indicator UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@controlled-by1
Patch Set: asdf Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-tooltip/paper-too ltip.html">
4 <link rel="import" href="cr_policy_indicator_behavior.html"> 5 <link rel="import" href="cr_policy_indicator_behavior.html">
5 <link rel="import" href="cr_policy_pref_behavior.html"> 6 <link rel="import" href="cr_policy_pref_behavior.html">
6 7
7 <dom-module id="cr-policy-pref-indicator"> 8 <dom-module id="cr-policy-pref-indicator">
8 <link rel="import" type="css" href="cr_policy_indicator.css"> 9 <link rel="import" type="css" href="cr_policy_indicator.css">
10 <style>
11 paper-tooltip {
12 --paper-tooltip: {
13 font-size: 92.31%; /* Effectively 12px if the host default is 13px. */
stevenjb 2016/05/27 20:45:09 92.31% seems... fragile. Grepping the existing cod
Dan Beam 2016/05/27 21:40:19 em and % are both scalable font-size units. getti
stevenjb 2016/05/27 21:54:12 So are you saying we should be using all three (px
Dan Beam 2016/05/27 22:00:49 no, we attempt to never use px when the font-size
14 font-weight: 500;
stevenjb 2016/05/27 20:45:09 We use 'bold' in a few places still, it would be g
Dan Beam 2016/05/27 21:40:20 chrome bundles Roboto with weights of 400, 500, an
stevenjb 2016/05/27 21:54:12 What abut 600, which we currently use in bluetooth
Dan Beam 2016/05/27 22:00:49 the situation may differ slightly on ChromeOS (I t
15 padding: 10px 8px;
16 };
17 }
18 </style>
9 <template> 19 <template>
10 <iron-icon id="indicator" 20 <iron-icon id="indicator" tabindex=0
11 hidden$="[[!isIndicatorVisible(indicatorType)]]" 21 hidden$="[[!isIndicatorVisible(indicatorType)]]"
12 icon="[[getPolicyIndicatorIcon(indicatorType)]]" 22 icon="[[getPolicyIndicatorIcon(indicatorType)]]"></iron-icon>
13 title$="[[getPolicyIndicatorTooltip(indicatorType, pref, controllingUser )]]"> 23 <paper-tooltip for="indicator" position="top">
14 </iron-icon> 24 [[getPolicyIndicatorTooltip(indicatorType, pref, controllingUser)]]
25 </paper-tooltip>
15 </template> 26 </template>
16 <script src="cr_policy_pref_indicator.js"></script> 27 <script src="cr_policy_pref_indicator.js"></script>
17 </dom-module> 28 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698