Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2019553002: Refactor dependencies for chromium_builder_perf target. (Closed)

Created:
4 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, nednguyen, scottmg, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor dependencies for chromium_builder_perf target. The perf bots build this target, but don't use isolates and therefore aren't on the same overall path as the bots which run telemetry_perf_unittests, where minidump processing is well tested. Make this target depend on telemetry_chrome_test, and remove redundant dependencies on chrome and bitmaptools. This should cause the tools which generate and process minidumps to be properly built. BUG=615180 Committed: https://crrev.com/1e58e78ecce28f5891912c000c5d2520e4f5b09d Cr-Commit-Position: refs/heads/master@{#396497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ken Russell (switch to Gerrit)
Ben or Brett: as src/ OWNERS please review. Thanks. dpranke is OOO. (I think more ...
4 years, 7 months ago (2016-05-27 01:58:00 UTC) #2
Dirk Pranke
lgtm. We should probably list the //build owners for BUILD.gn.
4 years, 6 months ago (2016-05-27 16:16:23 UTC) #4
brettw
LGTM
4 years, 6 months ago (2016-05-27 17:16:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019553002/1
4 years, 6 months ago (2016-05-27 17:17:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 17:21:31 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:23:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e58e78ecce28f5891912c000c5d2520e4f5b09d
Cr-Commit-Position: refs/heads/master@{#396497}

Powered by Google App Engine
This is Rietveld 408576698