Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java

Issue 2019533002: [Android] Fix crash when closing tab during infobar cancellation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test on mobile Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java
index 25884033d8750384d3f17e7e351081b65eaba62b..00a2bc95898707dca4438ac004754fb30b65c6e0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SimpleConfirmInfoBarBuilder.java
@@ -34,8 +34,10 @@ public class SimpleConfirmInfoBarBuilder {
*
* @param isPrimary True if the primary button was clicked, false if the secondary button
* was clicked.
+ * @return True if the listener caused the closing of this info bar as a side effect,
+ * false otherwise.
*/
- void onInfoBarButtonClicked(boolean isPrimary);
+ boolean onInfoBarButtonClicked(boolean isPrimary);
}
/**
@@ -81,8 +83,8 @@ public class SimpleConfirmInfoBarBuilder {
}
@CalledByNative
- private static void onInfoBarButtonClicked(Listener listener, boolean isPrimary) {
- if (listener != null) listener.onInfoBarButtonClicked(isPrimary);
+ private static boolean onInfoBarButtonClicked(Listener listener, boolean isPrimary) {
+ return listener == null ? false : listener.onInfoBarButtonClicked(isPrimary);
}
private static native void nativeCreate(

Powered by Google App Engine
This is Rietveld 408576698