Issue 201953002: Experimental parser: small fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201953002: Experimental parser: small fixes (Closed)

Created:
6 years, 9 months ago by dcarney

Modified:
6 years, 9 months ago

Reviewers:
marja

CC:
v8-dev, tfarina

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental parser: small fixes TBR=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20007

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -30 lines)			Patch
M	src/factory.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/factory.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/heap.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/lexer/lexer.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/lexer/lexer-shell.cc	View	1	6 chunks	+20 lines, -27 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dcarney

Committed patchset #2 manually as r20007 (presubmit successful).

6 years, 9 months ago (2014-03-17 15:57:27 UTC) #1

tfarina

6 years, 9 months ago (2014-03-19 17:36:50 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/201953002/diff/20001/src/lexer/lexer-shell.cc
File src/lexer/lexer-shell.cc (right):

https://codereview.chromium.org/201953002/diff/20001/src/lexer/lexer-shell.cc...
src/lexer/lexer-shell.cc:274: Token::Value value;
could you add trailing underscore to these member variables in a follow up CL
per Google C++ style guide? e.g., value_, beg_, etc...

Expand Messages | Collapse Messages