third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h - Issue 2019513004: Validate bound buffer for draw calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

Issue 2019513004: Validate bound buffer for draw calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

index bcf2d1b2ce804ec894bf4b07cdb4252f1025cfad..22f85b07de49313b14b1b6b7e01579f29b6912a6 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

@@ -33,6 +33,9 @@ public:

WebGLBuffer* getArrayBufferForAttrib(size_t);

void setArrayBufferForAttrib(GLuint, WebGLBuffer*);

+ void setAttribEnabled(GLuint, bool);

+ bool getAttribEnabled(GLuint);

+ bool isAllEnabledAttribBufferBound();

void unbindBuffer(WebGLBuffer*);

ScopedPersistent<v8::Array>* getPersistentCache();

@@ -54,6 +57,7 @@ private:

bool m_destructionInProgress;

Member<WebGLBuffer> m_boundElementArrayBuffer;

HeapVector<Member<WebGLBuffer>> m_arrayBufferList;

+ Vector<bool> m_attribEnabled;

// For preserving the wrappers of WebGLBuffer objects latched in

// via vertexAttribPointer calls.