command_buffer: MAX/BASE_LEVEL fixes for GetTexParameter

command_buffer: MAX/BASE_LEVEL fixes for GetTexParameter

This fixes two bugs for GetTexParameter:
 - It seems the OSX OpenGL driver stores the levels on int16_t causing
   the large values used by some tests to overflow and return as
   negative numbers. This is fixed by getting the values from the
   command buffer state tracking.
 - This exposed a bug in the state tracking where the base / max levels
   weren't rounded correctly when specified as floats.

BUG=483282
BUG=610153
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c2262abe85a3b1f03bf849ca670be2e505d34ec
Cr-Commit-Position: refs/heads/master@{#396864}

[Corentin Wallez, 2016-05-27 19:06:56]

Description was changed from

==========
command_buffer: MAX/BASE_LEVEL fixes for GetTexParameter

This fixes two bugs for GetTexParameter:
 - It seems the OSX OpenGL driver stores the levels on int16_t causing
   the large values used by some tests to overflow and return as
   negative numbers. This is fixed by getting the values from the
   command buffer state tracking.
 - This exposed a bug in the state tracking where the base / max levels
   weren't rounded correctly when specified as floats.

BUG=483282
==========

to

==========
command_buffer: MAX/BASE_LEVEL fixes for GetTexParameter

This fixes two bugs for GetTexParameter:
 - It seems the OSX OpenGL driver stores the levels on int16_t causing
   the large values used by some tests to overflow and return as
   negative numbers. This is fixed by getting the values from the
   command buffer state tracking.
 - This exposed a bug in the state tracking where the base / max levels
   weren't rounded correctly when specified as floats.

BUG=483282
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-05-27 19:07:28]

cwallez@chromium.org changed reviewers:
+ zmo@chromium.org

[Corentin Wallez, 2016-05-27 19:07:28]

PTAL, fixes one expectation on OSX.

[Zhenyao Mo, 2016-05-27 22:33:44]

Mostly looks good with one request.

Also, could you please use the BUG id 610153?

https://codereview.chromium.org/2019453003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2019453003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9275: // than 2^15-1 overflow in
the negative range.
Could you put this code behind a workaround? say, use_shadowed_tex_params?

This way we can turn it off and show driver vendors their bugs.

[Corentin Wallez, 2016-05-30 20:31:47]

Description was changed from

==========
command_buffer: MAX/BASE_LEVEL fixes for GetTexParameter

This fixes two bugs for GetTexParameter:
 - It seems the OSX OpenGL driver stores the levels on int16_t causing
   the large values used by some tests to overflow and return as
   negative numbers. This is fixed by getting the values from the
   command buffer state tracking.
 - This exposed a bug in the state tracking where the base / max levels
   weren't rounded correctly when specified as floats.

BUG=483282
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command_buffer: MAX/BASE_LEVEL fixes for GetTexParameter

This fixes two bugs for GetTexParameter:
 - It seems the OSX OpenGL driver stores the levels on int16_t causing
   the large values used by some tests to overflow and return as
   negative numbers. This is fixed by getting the values from the
   command buffer state tracking.
 - This exposed a bug in the state tracking where the base / max levels
   weren't rounded correctly when specified as floats.

BUG=483282
BUG=610153
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-05-30 20:32:10]

On 2016/05/27 at 22:33:44, zmo wrote:
> Mostly looks good with one request.
> 
> Also, could you please use the BUG id 610153?
> 
>
https://codereview.chromium.org/2019453003/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2019453003/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:9275: // than 2^15-1 overflow
in the negative range.
> Could you put this code behind a workaround? say, use_shadowed_tex_params?
> 
> This way we can turn it off and show driver vendors their bugs.

PTAL, added requested BUG and registered the driver bug workaround.

[Zhenyao Mo, 2016-05-31 01:42:48]

https://codereview.chromium.org/2019453003/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2019453003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9284: return;
"return" inside the if statement, and "break" here instead.

https://codereview.chromium.org/2019453003/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:9293: return;
"return" inside the if statement, and "break" here instead.

https://codereview.chromium.org/2019453003/diff/40001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2019453003/diff/40001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.68",
Update version info here.

https://codereview.chromium.org/2019453003/diff/40001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:2045: "description": "Mac Drivers store
texture lebel parameters on int16_t that overflow",
lebel -> level

[Corentin Wallez, 2016-05-31 13:54:27]

On 2016/05/31 at 01:42:48, zmo wrote:
>
https://codereview.chromium.org/2019453003/diff/40001/gpu/command_buffer/serv...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/2019453003/diff/40001/gpu/command_buffer/serv...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:9284: return;
> "return" inside the if statement, and "break" here instead.
> 
>
https://codereview.chromium.org/2019453003/diff/40001/gpu/command_buffer/serv...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:9293: return;
> "return" inside the if statement, and "break" here instead.
> 
>
https://codereview.chromium.org/2019453003/diff/40001/gpu/config/gpu_driver_b...
> File gpu/config/gpu_driver_bug_list_json.cc (right):
> 
>
https://codereview.chromium.org/2019453003/diff/40001/gpu/config/gpu_driver_b...
> gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.68",
> Update version info here.
> 
Done
>
https://codereview.chromium.org/2019453003/diff/40001/gpu/config/gpu_driver_b...
> gpu/config/gpu_driver_bug_list_json.cc:2045: "description": "Mac Drivers store
texture lebel parameters on int16_t that overflow",
> lebel -> level

[Zhenyao Mo, 2016-05-31 15:43:31]

lgtm

[Corentin Wallez, 2016-05-31 15:45:14]

On 2016/05/31 at 15:43:31, zmo wrote:
> lgtm

thanks

[Corentin Wallez, 2016-05-31 15:45:16]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-05-31 15:45:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2019453003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2019453003/60001

[commit-bot: I haz the power, 2016-05-31 18:12:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-31 18:13:58]

Description was changed from

==========
command_buffer: MAX/BASE_LEVEL fixes for GetTexParameter

This fixes two bugs for GetTexParameter:
 - It seems the OSX OpenGL driver stores the levels on int16_t causing
   the large values used by some tests to overflow and return as
   negative numbers. This is fixed by getting the values from the
   command buffer state tracking.
 - This exposed a bug in the state tracking where the base / max levels
   weren't rounded correctly when specified as floats.

BUG=483282
BUG=610153
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command_buffer: MAX/BASE_LEVEL fixes for GetTexParameter

This fixes two bugs for GetTexParameter:
 - It seems the OSX OpenGL driver stores the levels on int16_t causing
   the large values used by some tests to overflow and return as
   negative numbers. This is fixed by getting the values from the
   command buffer state tracking.
 - This exposed a bug in the state tracking where the base / max levels
   weren't rounded correctly when specified as floats.

BUG=483282
BUG=610153
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c2262abe85a3b1f03bf849ca670be2e505d34ec
Cr-Commit-Position: refs/heads/master@{#396864}
==========

[commit-bot: I haz the power, 2016-05-31 18:13:59]

Patchset 4 (id:??) landed as
https://crrev.com/6c2262abe85a3b1f03bf849ca670be2e505d34ec
Cr-Commit-Position: refs/heads/master@{#396864}