Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2019443002: Make CPDF_IndirectObjectHolder::InsertIndirectObject return a bool. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CPDF_IndirectObjectHolder::InsertIndirectObject return a bool. Fix some nits in CPDF_Parser::LoadCrossRefV5() and other callers. Committed: https://pdfium.googlesource.com/pdfium/+/2f1e05a44bbc38a4afea3fde8c8018dc127b8659

Patch Set 1 #

Patch Set 2 : Fix bad refactoring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -39 lines) Patch
M core/fpdfapi/fpdf_parser/cfdf_document.cpp View 3 chunks +18 lines, -19 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_indirect_object_holder.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 4 chunks +13 lines, -14 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-26 23:07:57 UTC) #3
Lei Zhang
Was waiting for green trybots before sending this out for review.
4 years, 7 months ago (2016-05-26 23:12:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019443002/20001
4 years, 7 months ago (2016-05-26 23:21:01 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 23:24:21 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/2f1e05a44bbc38a4afea3fde8c8018dc127b...

Powered by Google App Engine
This is Rietveld 408576698