Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2019433003: [Interpreter] Add intrinsic for Runtime::kInlineCall. (Closed)

Created:
4 years, 6 months ago by rmcilroy
Modified:
4 years, 6 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add intrinsic for Runtime::kInlineCall. One of the top runtime calls in many workloads is Runtime_Call. Add an intrinsic for the interpreter to inline this runtime call. BUG=v8:4280 LOG=N Committed: https://crrev.com/aff90bc15b548fa5e6202e82031413bea1e7fc6b Cr-Commit-Position: refs/heads/master@{#36565}

Patch Set 1 #

Patch Set 2 : Rebaseline expectations #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Rebase #

Patch Set 5 : Fix spelling #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -27 lines) Patch
M src/interpreter/interpreter.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 2 3 4 4 chunks +34 lines, -11 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 2 3 4 5 8 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-interpreter-intrinsics.cc View 2 chunks +23 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1902263007 Patch 1

Messages

Total messages: 30 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019433003/1
4 years, 6 months ago (2016-05-27 09:59:10 UTC) #2
rmcilroy
Orion, PTAL, thanks.
4 years, 6 months ago (2016-05-27 09:59:25 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/2271) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 6 months ago (2016-05-27 10:14:06 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019433003/20001
4 years, 6 months ago (2016-05-27 10:18:55 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/18270) v8_linux64_avx2_rel_ng on ...
4 years, 6 months ago (2016-05-27 10:20:06 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019433003/40001
4 years, 6 months ago (2016-05-27 12:39:31 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 13:03:21 UTC) #14
oth
Nice, lgtm. A couple of minor spelling mistakes. https://codereview.chromium.org/2019433003/diff/40001/src/interpreter/interpreter-intrinsics.cc File src/interpreter/interpreter-intrinsics.cc (right): https://codereview.chromium.org/2019433003/diff/40001/src/interpreter/interpreter-intrinsics.cc#newcode149 src/interpreter/interpreter-intrinsics.cc:149: // ...
4 years, 6 months ago (2016-05-27 13:11:04 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019433003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019433003/80001
4 years, 6 months ago (2016-05-27 13:36:49 UTC) #17
rmcilroy
https://codereview.chromium.org/2019433003/diff/40001/src/interpreter/interpreter-intrinsics.cc File src/interpreter/interpreter-intrinsics.cc (right): https://codereview.chromium.org/2019433003/diff/40001/src/interpreter/interpreter-intrinsics.cc#newcode149 src/interpreter/interpreter-intrinsics.cc:149: // Reciever is the second runtime call argument. On ...
4 years, 6 months ago (2016-05-27 13:37:00 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 13:56:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019433003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019433003/80001
4 years, 6 months ago (2016-05-27 21:56:56 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019433003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019433003/100001
4 years, 6 months ago (2016-05-27 22:04:46 UTC) #27
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-05-27 22:29:14 UTC) #28
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 22:30:56 UTC) #30
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/aff90bc15b548fa5e6202e82031413bea1e7fc6b
Cr-Commit-Position: refs/heads/master@{#36565}

Powered by Google App Engine
This is Rietveld 408576698