Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: net/spdy/spdy_protocol.cc

Issue 201943003: Minor logging change for catching development errors during testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol.cc
diff --git a/net/spdy/spdy_protocol.cc b/net/spdy/spdy_protocol.cc
index a5f3a1c679198be225f1bb416f2b66937001f18f..157993caff8afc21e91ef5abfab360ac7cce6241 100644
--- a/net/spdy/spdy_protocol.cc
+++ b/net/spdy/spdy_protocol.cc
@@ -85,8 +85,6 @@ SpdyFrameType SpdyConstants::ParseFrameType(SpdyMajorVersion version,
return HEADERS;
case 9:
return WINDOW_UPDATE;
- default:
- return DATA;
}
case SPDY4:
switch (frame_type_field) {
@@ -111,10 +109,10 @@ SpdyFrameType SpdyConstants::ParseFrameType(SpdyMajorVersion version,
return CONTINUATION;
case 10:
return BLOCKED;
- default:
- return DATA;
}
}
+
+ LOG(DFATAL) << "Unhandled frame type " << frame_type_field;
return DATA;
}
@@ -141,6 +139,7 @@ int SpdyConstants::SerializeFrameType(SpdyMajorVersion version,
case WINDOW_UPDATE:
return 9;
default:
+ LOG(DFATAL) << "Serializing unhandled frame type " << frame_type;
return -1;
}
case SPDY4:
@@ -167,6 +166,7 @@ int SpdyConstants::SerializeFrameType(SpdyMajorVersion version,
case BLOCKED:
return 10;
default:
+ LOG(DFATAL) << "Serializing unhandled frame type " << frame_type;
return -1;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698