Re-enable extensions disabled due to permission increase if they have all permissions

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <iterator>
@@ skipping 1593 matching lines @@
             extension->GetType());
 
     // If there was no privilege increase, the extension might still have new
     // permissions (which either don't generate a warning message, or whose
     // warning messages are suppressed by existing permissions). Grant the new
     // permissions.
     if (!is_privilege_increase)
       GrantPermissions(extension);
   }
 
-  if (is_extension_installed) {
-    // If the extension was already disabled, suppress any alerts for becoming
-    // disabled on permissions increase.
-    bool previously_disabled =
-        extension_prefs_->IsExtensionDisabled(extension->id());
+  bool previously_disabled =
+      extension_prefs_->IsExtensionDisabled(extension->id());
+  if (is_extension_installed && previously_disabled) {
     // Legacy disabled extensions do not have a disable reason. Infer that it
     // was likely disabled by the user.
-    if (previously_disabled && disable_reasons == Extension::DISABLE_NONE)
+    if (disable_reasons == Extension::DISABLE_NONE)
       disable_reasons |= Extension::DISABLE_USER_ACTION;
 
     // Extensions that came to us disabled from sync need a similar inference,
     // except based on the new version's permissions.
     // TODO(treib,devlin): Since M48, DISABLE_UNKNOWN_FROM_SYNC isn't used
     // anymore; this code is still here to migrate any existing old state.
     // Remove it after some grace period.
-    if (previously_disabled &&
-        (disable_reasons & Extension::DEPRECATED_DISABLE_UNKNOWN_FROM_SYNC)) {
+    if (disable_reasons & Extension::DEPRECATED_DISABLE_UNKNOWN_FROM_SYNC) {
       // Remove the DISABLE_UNKNOWN_FROM_SYNC reason.
       disable_reasons &= ~Extension::DEPRECATED_DISABLE_UNKNOWN_FROM_SYNC;
       extension_prefs_->RemoveDisableReason(
           extension->id(), Extension::DEPRECATED_DISABLE_UNKNOWN_FROM_SYNC);
       // If there was no privilege increase, it was likely disabled by the user.
       if (!is_privilege_increase)
         disable_reasons |= Extension::DISABLE_USER_ACTION;
     }
   }
 
+  // If the extension is disabled due to a permissions increase, but does in
+  // fact have all permissions, remove that disable reason.

[Marc Treib, 2016/06/10 14:12:17]

To make the "startup" case work, I had to pull this out of the "if
(is_extension_installed)" - turns out |is_extension_installed| is false during
startup, even if the extension was previously installed. Misleading names ftw
:-/
In fact, I can't see a reason why this check is even there at all. Removing it
doesn't seem to break anything, though from experience, that doesn't mean
much...

[Devlin, 2016/06/10 19:05:52]

Can you add a TODO to rename it on line 1442?  Something like:
// TODO([devlin|treib]): This is incorrect during startup, where the extension
isn't already loaded, but may have been installed.

(option b: rename it in this CL - up to you ;))

[Marc Treib, 2016/06/13 11:54:59]

Done.
I also added a TODO in CheckPermissionsIncrease, (a) to explain the same thing,
a (2) since I think we don't actually need it there.
Sure, I can do that - what would be a good name? is_extension_loaded?

[Devlin, 2016/06/13 13:51:50]

is_extension_loaded sgtm

[Marc Treib, 2016/06/14 15:24:26]

Done, and removed/updated the TODOs accordingly.

+  if (previously_disabled && !is_privilege_increase &&

[Devlin, 2016/06/10 19:05:52]

Add:
// TODO(devlin): This was added to fix crbug.com/616474, but it's unclear
// if this behavior should stay forever.

[Marc Treib, 2016/06/13 11:54:59]

Done.

+      (disable_reasons & Extension::DISABLE_PERMISSIONS_INCREASE)) {
+    disable_reasons &= ~Extension::DISABLE_PERMISSIONS_INCREASE;
+    extension_prefs_->RemoveDisableReason(
+        extension->id(), Extension::DISABLE_PERMISSIONS_INCREASE);

[Devlin, 2016/06/10 19:05:52]

I wonder if we should add some UMA for this.  I'm expecting this to be
relatively rare, but if we see ourselves re-enabling bunches of extensions, it'd
at least be good to know.

[Marc Treib, 2016/06/13 11:54:59]

Added a binary histogram. PTAL.

+  }
+
   // Extension has changed permissions significantly. Disable it. A
   // notification should be sent by the caller. If the extension is already
   // disabled because it was installed remotely, don't add another disable
   // reason.
   if (is_privilege_increase &&
       !(disable_reasons & Extension::DISABLE_REMOTE_INSTALL)) {
     disable_reasons |= Extension::DISABLE_PERMISSIONS_INCREASE;
     if (!extension_prefs_->DidExtensionEscalatePermissions(extension->id()))
       RecordPermissionMessagesHistogram(extension, "AutoDisable");
 
 #if defined(ENABLE_SUPERVISED_USERS)
     // If a custodian-installed extension is disabled for a supervised user due
     // to a permissions increase, send a request to the custodian if the
     // supervised user themselves can't re-enable the extension.
     if (extensions::util::IsExtensionSupervised(extension, profile_) &&
         extensions::util::NeedCustodianApprovalForPermissionIncrease(
             profile_) &&
         !ExtensionSyncService::Get(profile_)->HasPendingReenable(
             extension->id(), *extension->version())) {
       SupervisedUserService* supervised_user_service =
           SupervisedUserServiceFactory::GetForProfile(profile_);
       supervised_user_service->AddExtensionUpdateRequest(extension->id(),
                                                          *extension->version());
     }
 #endif
   }
-  if (disable_reasons != Extension::DISABLE_NONE)
+
+  if (disable_reasons == Extension::DISABLE_NONE)
+    extension_prefs_->SetExtensionEnabled(extension->id());
+  else
     extension_prefs_->SetExtensionDisabled(extension->id(), disable_reasons);
 }
 
 void ExtensionService::UpdateActiveExtensionsInCrashReporter() {
   std::set<std::string> extension_ids;
   for (const auto& extension : registry_->enabled_extensions()) {
     if (!extension->is_theme() && extension->location() != Manifest::COMPONENT)
       extension_ids.insert(extension->id());
   }
 
@@ skipping 757 matching lines @@
 }
 
 void ExtensionService::OnProfileDestructionStarted() {
   ExtensionIdSet ids_to_unload = registry_->enabled_extensions().GetIDs();
   for (ExtensionIdSet::iterator it = ids_to_unload.begin();
        it != ids_to_unload.end();
        ++it) {
     UnloadExtension(*it, UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN);
   }
 }