Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2019423005: Move //components/ui/zoom to top-level under //components (Closed)

Created:
4 years, 6 months ago by juncai
Modified:
4 years, 6 months ago
CC:
blundell+watchlist_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-options_chromium.org, dcheng, devtools-reviews_chromium.org, Dmitry Titov, droger+watchlist_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, jennb, jianli, michaelpg+watch-options_chromium.org, pfeldman, rouslan+autofill_chromium.org, sdefresne+watchlist_chromium.org, tfarina, vabr+watchlistautofill_chromium.org, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move //components/ui/zoom to top-level under //components There is no pattern in //components of organizing individual components by logical module. This patch moved //components/ui/zoom to top-level under //components. BUG=615568 Committed: https://crrev.com/a64f769c27e011b8304159cc4779592945278b64 Cr-Commit-Position: refs/heads/master@{#397871}

Patch Set 1 : moved //components/ui/zoom to top-level under //components #

Patch Set 2 : fixed compile error on Mac and ChromeOS #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -1637 lines) Patch
M chrome/browser/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browser_commands_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_event_router.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/pdf/pdf_extension_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/host_zoom_map_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/start_page_service.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm View 4 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_unittest.mm View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu.cc View 1 2 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/zoom/chrome_zoom_level_otr_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/zoom/chrome_zoom_level_otr_delegate.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/zoom/chrome_zoom_level_prefs.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/components.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M components/guest_view/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/guest_view/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/guest_view/browser/guest_view_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/guest_view/browser/guest_view_base.cc View 9 chunks +14 lines, -15 lines 0 comments Download
D components/ui/zoom/BUILD.gn View 1 chunk +0 lines, -54 lines 0 comments Download
D components/ui/zoom/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D components/ui/zoom/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/ui/zoom/page_zoom.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/ui/zoom/page_zoom.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D components/ui/zoom/page_zoom_constants.h View 1 chunk +0 lines, -22 lines 0 comments Download
D components/ui/zoom/page_zoom_constants.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D components/ui/zoom/page_zoom_unittests.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D components/ui/zoom/test/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/ui/zoom/test/zoom_test_utils.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/ui/zoom/test/zoom_test_utils.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D components/ui/zoom/zoom_controller.h View 1 chunk +0 lines, -204 lines 0 comments Download
D components/ui/zoom/zoom_controller.cc View 1 chunk +0 lines, -376 lines 0 comments Download
D components/ui/zoom/zoom_event_manager.h View 1 chunk +0 lines, -75 lines 0 comments Download
D components/ui/zoom/zoom_event_manager.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D components/ui/zoom/zoom_event_manager_observer.h View 1 chunk +0 lines, -23 lines 0 comments Download
D components/ui/zoom/zoom_observer.h View 1 chunk +0 lines, -25 lines 0 comments Download
D components/ui_zoom.gypi View 1 chunk +0 lines, -53 lines 0 comments Download
A + components/zoom.gypi View 3 chunks +16 lines, -16 lines 0 comments Download
A + components/zoom/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/zoom/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/zoom/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/zoom/page_zoom.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/zoom/page_zoom.cc View 7 chunks +15 lines, -15 lines 0 comments Download
A + components/zoom/page_zoom_constants.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/zoom/page_zoom_constants.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + components/zoom/page_zoom_unittests.cc View 4 chunks +7 lines, -10 lines 0 comments Download
A + components/zoom/test/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/zoom/test/zoom_test_utils.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + components/zoom/test/zoom_test_utils.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/zoom/zoom_controller.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/zoom/zoom_controller.cc View 5 chunks +13 lines, -14 lines 0 comments Download
A + components/zoom/zoom_event_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/zoom/zoom_event_manager.cc View 3 chunks +6 lines, -8 lines 0 comments Download
A + components/zoom/zoom_event_manager_observer.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/zoom/zoom_observer.h View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/guest_view/web_view/web_view_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_zoom_request_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (13 generated)
juncai
blundell@chromium.org: Please review changes in //components reillyg@chromium.org: Please review changes in //extensions sky@chromium.org: Please review ...
4 years, 6 months ago (2016-05-31 18:47:32 UTC) #4
juncai
rockot@chromium.org: Please review changes in //extensions/browser/DEPS
4 years, 6 months ago (2016-05-31 18:57:52 UTC) #6
Ken Rockot(use gerrit already)
rs lgtm
4 years, 6 months ago (2016-05-31 19:00:06 UTC) #7
Reilly Grant (use Gerrit)
lgtm
4 years, 6 months ago (2016-05-31 19:06:04 UTC) #8
sky
LGTM
4 years, 6 months ago (2016-05-31 20:58:27 UTC) #9
blundell
lgtm, thanks!
4 years, 6 months ago (2016-06-02 08:11:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019423005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019423005/20001
4 years, 6 months ago (2016-06-02 13:12:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/15203) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-02 13:15:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019423005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019423005/40001
4 years, 6 months ago (2016-06-02 21:45:18 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/194294)
4 years, 6 months ago (2016-06-02 22:13:41 UTC) #19
juncai
presubmit failed because: Missing LGTM from OWNERS of dependencies added to DEPS: '+content/public/browser', '+content/public/common', '+ipc', ...
4 years, 6 months ago (2016-06-02 22:19:26 UTC) #21
Avi (use Gerrit)
lgtm stampity stamp
4 years, 6 months ago (2016-06-02 22:32:51 UTC) #22
agl
LGTM. I do not see anything here that requires my review, but LGTM in case ...
4 years, 6 months ago (2016-06-02 22:50:02 UTC) #23
Tom Sepez
DEPS LGTM
4 years, 6 months ago (2016-06-02 23:46:46 UTC) #24
brettw
lgtm
4 years, 6 months ago (2016-06-03 22:06:47 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019423005/40001
4 years, 6 months ago (2016-06-03 22:15:28 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-04 00:55:52 UTC) #29
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:58:43 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a64f769c27e011b8304159cc4779592945278b64
Cr-Commit-Position: refs/heads/master@{#397871}

Powered by Google App Engine
This is Rietveld 408576698