Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2019393002: VectorICs: Remove special code to increment call counts by two. (Closed)

Created:
4 years, 6 months ago by mvstanton
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: Remove special code to increment call counts by two. Previously, we used the lowest bit for something else. R=bmeurer@chromium.org Committed: https://crrev.com/63ea3a500980e8d0935a998e6d86c0256b15c283 Cr-Commit-Position: refs/heads/master@{#36599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -27 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/type-feedback-vector.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/type-feedback-vector.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mvstanton
Hi Benedikt, PTAL at this thing, thx! --Mike
4 years, 6 months ago (2016-05-30 14:48:10 UTC) #3
Benedikt Meurer
Awesome, LGTM!
4 years, 6 months ago (2016-05-30 17:50:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019393002/1
4 years, 6 months ago (2016-05-30 20:40:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 20:42:52 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 20:45:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63ea3a500980e8d0935a998e6d86c0256b15c283
Cr-Commit-Position: refs/heads/master@{#36599}

Powered by Google App Engine
This is Rietveld 408576698