Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: testing/embedder_test.cpp

Issue 2019383002: Fix V8 isolate setup in embedder tests and roll V8 to 055bfa7. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: updates Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | testing/js_embedder_test.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/embedder_test.cpp
diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp
index 033313dbe24a0519350ef3650536cc042b67e727..3d3b2ad844832c0617e1b71b138c3abcb1ccb5e5 100644
--- a/testing/embedder_test.cpp
+++ b/testing/embedder_test.cpp
@@ -58,7 +58,12 @@ EmbedderTest::EmbedderTest()
#endif // FPDF_ENABLE_V8
}
-EmbedderTest::~EmbedderTest() {}
+EmbedderTest::~EmbedderTest() {
+#ifdef PDF_ENABLE_V8
+ v8::V8::ShutdownPlatform();
+ delete platform_;
+#endif // PDF_ENABLE_V8
+}
void EmbedderTest::SetUp() {
FPDF_LIBRARY_CONFIG config;
@@ -93,11 +98,6 @@ void EmbedderTest::TearDown() {
FPDFAvail_Destroy(avail_);
FPDF_DestroyLibrary();
-#ifdef PDF_ENABLE_V8
- v8::V8::ShutdownPlatform();
- delete platform_;
-#endif // PDF_ENABLE_V8
-
delete loader_;
}
« no previous file with comments | « DEPS ('k') | testing/js_embedder_test.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698