Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2019383002: Fix V8 isolate setup in embedder tests and roll V8 to 055bfa7. (Closed)

Created:
4 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix V8 isolate setup in embedder tests and roll V8 to 055bfa7. R=thestig@chromium.org BUG= Committed: https://pdfium.googlesource.com/pdfium/+/38a1f0a14bf17512f89bb5c7ed82847ba46456fa

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M testing/js_embedder_test.cpp View 1 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jochen (gone - plz use gerrit)
4 years, 6 months ago (2016-05-30 14:20:04 UTC) #1
Lei Zhang
https://codereview.chromium.org/2019383002/diff/1/testing/js_embedder_test.cpp File testing/js_embedder_test.cpp (right): https://codereview.chromium.org/2019383002/diff/1/testing/js_embedder_test.cpp#newcode17 testing/js_embedder_test.cpp:17: m_pIsolate = v8::Isolate::New(params); Is this going to leak?
4 years, 6 months ago (2016-05-30 20:19:20 UTC) #2
jochen (gone - plz use gerrit)
On 2016/05/30 at 20:19:20, thestig wrote: > https://codereview.chromium.org/2019383002/diff/1/testing/js_embedder_test.cpp > File testing/js_embedder_test.cpp (right): > > https://codereview.chromium.org/2019383002/diff/1/testing/js_embedder_test.cpp#newcode17 ...
4 years, 6 months ago (2016-05-30 20:31:26 UTC) #3
Lei Zhang
On 2016/05/30 20:31:26, jochen wrote: > We could also move the document destruction to a ...
4 years, 6 months ago (2016-05-30 20:58:35 UTC) #4
jochen (gone - plz use gerrit)
ptal
4 years, 6 months ago (2016-05-31 11:07:29 UTC) #5
Lei Zhang
lgtm, thank you!
4 years, 6 months ago (2016-05-31 19:07:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019383002/20001
4 years, 6 months ago (2016-05-31 19:07:27 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 19:07:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/38a1f0a14bf17512f89bb5c7ed82847ba464...

Powered by Google App Engine
This is Rietveld 408576698