Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: chrome/browser/printing/print_preview_dialog_controller.cc

Issue 2019373002: Fix page transition qualifiers not masked out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added one more occurrence. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tab_contents/navigation_metrics_recorder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_preview_dialog_controller.cc
diff --git a/chrome/browser/printing/print_preview_dialog_controller.cc b/chrome/browser/printing/print_preview_dialog_controller.cc
index 125a81b67764b6d34895afac342af4e8d5338480..6d91353345ed72778feaa3e7c48a3efc2f73a490 100644
--- a/chrome/browser/printing/print_preview_dialog_controller.cc
+++ b/chrome/browser/printing/print_preview_dialog_controller.cc
@@ -336,7 +336,8 @@ void PrintPreviewDialogController::OnNavEntryCommitted(
// New |preview_dialog| is created. Don't update/erase map entry.
if (waiting_for_new_preview_page_ &&
- transition_type == ui::PAGE_TRANSITION_AUTO_TOPLEVEL &&
+ ui::PageTransitionCoreTypeIs(transition_type,
+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL) &&
nav_type == content::NAVIGATION_TYPE_NEW_PAGE) {
waiting_for_new_preview_page_ = false;
SaveInitiatorTitle(preview_dialog);
@@ -345,7 +346,8 @@ void PrintPreviewDialogController::OnNavEntryCommitted(
// Cloud print sign-in causes a reload.
if (!waiting_for_new_preview_page_ &&
- transition_type == ui::PAGE_TRANSITION_RELOAD &&
+ ui::PageTransitionCoreTypeIs(transition_type,
+ ui::PAGE_TRANSITION_RELOAD) &&
nav_type == content::NAVIGATION_TYPE_EXISTING_PAGE &&
IsPrintPreviewURL(details->previous_url)) {
return;
« no previous file with comments | « no previous file | chrome/browser/tab_contents/navigation_metrics_recorder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698