Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2019363002: Revert of [Sync] Clean up Android test code a bit. (Closed)

Created:
4 years, 6 months ago by clamy
Modified:
4 years, 6 months ago
Reviewers:
nyquist, pavely, maxbogue
CC:
chromium-reviews, zine-eng+reviews_google.com, sync-reviews_chromium.org, Patrick Noland
Base URL:
https://chromium.googlesource.com/chromium/src.git@signin-test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Clean up Android test code a bit. (patchset #3 id:40001 of https://codereview.chromium.org/2009603005/ ) Reason for revert: This is breaking compilation on the Android ToT downstream bot, so reverting since this is an Android only patch (see https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/clang-clankium-tot-builder/builds/27798/steps/compile/logs/stdio ) Original issue's description: > [Sync] Clean up Android test code a bit. > > - Remove SigninTestUtil.get() and make it a fully static class. > - Add SigninTestUtil.getCurrentAccount() for convenience. > - setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's > no such thing as signing in to sync. > - Remove SyncTestUtil.verify* and replace with asserts on SyncTestUtil.isSyncRequested > and SigninTestUtil.getCurrentAccount. > - Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve > a flake related to signin state. > > BUG= > > Committed: https://crrev.com/0b76f4432df2571fd8883419153fc871a74567f3 > Cr-Commit-Position: refs/heads/master@{#396648} TBR=pavely@chromium.org,nyquist@chromium.org,maxbogue@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/f94b7ad600368c3b3abbe97e36673748d6912598 Cr-Commit-Position: refs/heads/master@{#396718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -138 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/interests/InterestsServiceTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/AutofillTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/BookmarksTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java View 4 chunks +17 lines, -12 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java View 19 chunks +19 lines, -19 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 7 chunks +29 lines, -27 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseTypeDialogFragmentTest.java View 2 chunks +12 lines, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/signin/SigninTestUtil.java View 4 chunks +31 lines, -28 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java View 6 chunks +57 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
clamy
Created Revert of [Sync] Clean up Android test code a bit.
4 years, 6 months ago (2016-05-30 12:22:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019363002/1
4 years, 6 months ago (2016-05-30 12:23:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 12:56:27 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 12:58:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f94b7ad600368c3b3abbe97e36673748d6912598
Cr-Commit-Position: refs/heads/master@{#396718}

Powered by Google App Engine
This is Rietveld 408576698