Created Revert of [Sync] Clean up Android test code a bit.
4 years, 6 months ago
(2016-05-30 12:22:44 UTC)
#2
Created Revert of [Sync] Clean up Android test code a bit.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019363002/1
4 years, 6 months ago
(2016-05-30 12:23:02 UTC)
#3
4 years, 6 months ago
(2016-05-30 12:56:27 UTC)
#4
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of [Sync] Clean up Android test code a bit. ...
4 years, 6 months ago
(2016-05-30 12:58:03 UTC)
#5
Message was sent while issue was closed.
Description was changed from
==========
Revert of [Sync] Clean up Android test code a bit. (patchset #3 id:40001 of
https://codereview.chromium.org/2009603005/ )
Reason for revert:
This is breaking compilation on the Android ToT downstream bot, so reverting
since this is an Android only patch (see
https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/cla...
)
Original issue's description:
> [Sync] Clean up Android test code a bit.
>
> - Remove SigninTestUtil.get() and make it a fully static class.
> - Add SigninTestUtil.getCurrentAccount() for convenience.
> - setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
> no such thing as signing in to sync.
> - Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
> and SigninTestUtil.getCurrentAccount.
> - Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
> a flake related to signin state.
>
> BUG=
>
> Committed: https://crrev.com/0b76f4432df2571fd8883419153fc871a74567f3
> Cr-Commit-Position: refs/heads/master@{#396648}
TBR=pavely@chromium.org,nyquist@chromium.org,maxbogue@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
==========
to
==========
Revert of [Sync] Clean up Android test code a bit. (patchset #3 id:40001 of
https://codereview.chromium.org/2009603005/ )
Reason for revert:
This is breaking compilation on the Android ToT downstream bot, so reverting
since this is an Android only patch (see
https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/cla...
)
Original issue's description:
> [Sync] Clean up Android test code a bit.
>
> - Remove SigninTestUtil.get() and make it a fully static class.
> - Add SigninTestUtil.getCurrentAccount() for convenience.
> - setUpTestAccountAndSignInToSync -> setUpTestAccountAndSignIn because there's
> no such thing as signing in to sync.
> - Remove SyncTestUtil.verify* and replace with asserts on
SyncTestUtil.isSyncRequested
> and SigninTestUtil.getCurrentAccount.
> - Make PassphraseTypeDialogFragmentTest inherit from SyncTestBase to resolve
> a flake related to signin state.
>
> BUG=
>
> Committed: https://crrev.com/0b76f4432df2571fd8883419153fc871a74567f3
> Cr-Commit-Position: refs/heads/master@{#396648}
TBR=pavely@chromium.org,nyquist@chromium.org,maxbogue@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
Committed: https://crrev.com/f94b7ad600368c3b3abbe97e36673748d6912598
Cr-Commit-Position: refs/heads/master@{#396718}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f94b7ad600368c3b3abbe97e36673748d6912598 Cr-Commit-Position: refs/heads/master@{#396718}
4 years, 6 months ago
(2016-05-30 12:58:04 UTC)
#6
Issue 2019363002: Revert of [Sync] Clean up Android test code a bit.
(Closed)
Created 4 years, 6 months ago by clamy
Modified 4 years, 6 months ago
Reviewers: pavely, nyquist, maxbogue
Base URL: https://chromium.googlesource.com/chromium/src.git@signin-test
Comments: 0