Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2019343002:
[heap] Simulate aborting compaction during --stress-compaction (Closed)
|
Created:
4 years, 6 months ago by Michael Lippautz Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Simulate aborting compaction during --stress-compaction
How to trigger (stress bots do all steps):
1. Enable in gyp/gn: v8_enable_verify_heap
2. Start with --stress-compaction and non-zero --random-seed
R=ulan@chromium.org, hpayer@chromium.org
BUG=
CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg
Committed: https://crrev.com/2f5ba83bc0c8cc97fe94987e7b8e4ec91dac4637
Cr-Commit-Position: refs/heads/master@{#36619}
Patch Set 1 : #
Total comments: 2
Patch Set 2 : Addressed comment #
Messages
Total messages: 23 (14 generated)
Description was changed from ========== [heap] Simulate aborting compaction during --stress-compaction. Only do so if compiled with v8_enable_verify_heap. BUG= ========== to ========== [heap] Simulate aborting compaction during --stress-compaction. Only do so if compiled with v8_enable_verify_heap. R=ulan@chromium.org, hpayer@chromium.org BUG= ==========
Description was changed from ========== [heap] Simulate aborting compaction during --stress-compaction. Only do so if compiled with v8_enable_verify_heap. R=ulan@chromium.org, hpayer@chromium.org BUG= ========== to ========== [heap] Simulate aborting compaction during --stress-compaction Only do so if compiled with v8_enable_verify_heap. R=ulan@chromium.org, hpayer@chromium.org BUG= ==========
Description was changed from ========== [heap] Simulate aborting compaction during --stress-compaction Only do so if compiled with v8_enable_verify_heap. R=ulan@chromium.org, hpayer@chromium.org BUG= ========== to ========== [heap] Simulate aborting compaction during --stress-compaction How to trigger: 1. Enable in gyp/gn: v8_enable_verify_heap 2. Start with --stress-compaction and non-zero --random-seed R=ulan@chromium.org, hpayer@chromium.org BUG= ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org, ulan@chromium.org
ptal The distribution it produces when running on one of the GPU tests: 0 (aborted): 474 1: 64 2: 5 3: 0
Description was changed from ========== [heap] Simulate aborting compaction during --stress-compaction How to trigger: 1. Enable in gyp/gn: v8_enable_verify_heap 2. Start with --stress-compaction and non-zero --random-seed R=ulan@chromium.org, hpayer@chromium.org BUG= ========== to ========== [heap] Simulate aborting compaction during --stress-compaction How to trigger (stress bots do all steps): 1. Enable in gyp/gn: v8_enable_verify_heap 2. Start with --stress-compaction and non-zero --random-seed R=ulan@chromium.org, hpayer@chromium.org BUG= ==========
lgtm
Description was changed from ========== [heap] Simulate aborting compaction during --stress-compaction How to trigger (stress bots do all steps): 1. Enable in gyp/gn: v8_enable_verify_heap 2. Start with --stress-compaction and non-zero --random-seed R=ulan@chromium.org, hpayer@chromium.org BUG= ========== to ========== [heap] Simulate aborting compaction during --stress-compaction How to trigger (stress bots do all steps): 1. Enable in gyp/gn: v8_enable_verify_heap 2. Start with --stress-compaction and non-zero --random-seed R=ulan@chromium.org, hpayer@chromium.org BUG= CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019343002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2019343002/diff/40001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/2019343002/diff/40001/src/heap/mark-compact.c... src/heap/mark-compact.cc:1644: #ifdef VERIFY_HEAP Can we move that code into a SimulateCompactionAbortion function which is only called in VERIFY_HEAP? That keeps the main function small.
https://codereview.chromium.org/2019343002/diff/40001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/2019343002/diff/40001/src/heap/mark-compact.c... src/heap/mark-compact.cc:1644: #ifdef VERIFY_HEAP On 2016/05/31 14:01:04, Hannes Payer wrote: > Can we move that code into a SimulateCompactionAbortion function which is only > called in VERIFY_HEAP? That keeps the main function small. Done.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org, ulan@chromium.org Link to the patchset: https://codereview.chromium.org/2019343002/#ps60001 (title: "Addressed comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019343002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019343002/60001
Message was sent while issue was closed.
Description was changed from ========== [heap] Simulate aborting compaction during --stress-compaction How to trigger (stress bots do all steps): 1. Enable in gyp/gn: v8_enable_verify_heap 2. Start with --stress-compaction and non-zero --random-seed R=ulan@chromium.org, hpayer@chromium.org BUG= CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg ========== to ========== [heap] Simulate aborting compaction during --stress-compaction How to trigger (stress bots do all steps): 1. Enable in gyp/gn: v8_enable_verify_heap 2. Start with --stress-compaction and non-zero --random-seed R=ulan@chromium.org, hpayer@chromium.org BUG= CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Simulate aborting compaction during --stress-compaction How to trigger (stress bots do all steps): 1. Enable in gyp/gn: v8_enable_verify_heap 2. Start with --stress-compaction and non-zero --random-seed R=ulan@chromium.org, hpayer@chromium.org BUG= CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg ========== to ========== [heap] Simulate aborting compaction during --stress-compaction How to trigger (stress bots do all steps): 1. Enable in gyp/gn: v8_enable_verify_heap 2. Start with --stress-compaction and non-zero --random-seed R=ulan@chromium.org, hpayer@chromium.org BUG= CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg Committed: https://crrev.com/2f5ba83bc0c8cc97fe94987e7b8e4ec91dac4637 Cr-Commit-Position: refs/heads/master@{#36619} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2f5ba83bc0c8cc97fe94987e7b8e4ec91dac4637 Cr-Commit-Position: refs/heads/master@{#36619} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
