[Offline Pages] Fix crash due to table inconsistency.

components/offline_pages/offline_page_metadata_store_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_metadata_store.h"
 
 #include <stdint.h>
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "components/offline_pages/offline_page_item.h"
 #include "components/offline_pages/offline_page_metadata_store_sql.h"
 #include "components/offline_pages/offline_page_model.h"
+#include "sql/connection.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace offline_pages {
 
 namespace {
 
+#define OFFLINE_PAGES_TABLE_NAME "offlinepages_v1"
+
 const char kTestClientNamespace[] = "CLIENT_NAMESPACE";
 const char kTestURL[] = "https://example.com";
 const ClientId kTestClientId1(kTestClientNamespace, "1234");
 const ClientId kTestClientId2(kTestClientNamespace, "5678");
 const base::FilePath::CharType kFilePath[] =
     FILE_PATH_LITERAL("/offline_pages/example_com.mhtml");
 int64_t kFileSize = 234567;
 
+// Build a store with outdated schema to simulate the upgrading process.
+// TODO(romax): move it to sql_unittests.

[fgorski, 2016/06/03 18:17:16]

good point.

Another test that we should include in upgrades is working with existing data,
which should also find its way to extracted tests.

[romax, 2016/06/03 19:36:22]

i've combined this case with the newly added test.

+void BuildBadTable(const base::FilePath& file) {

[fgorski, 2016/06/03 18:17:16]

How about BuildStoreV1 (and then look at the comment below)

[romax, 2016/06/03 19:36:22]

Done.

+  sql::Connection connection;
+  ASSERT_TRUE(
+      connection.Open(file.Append(FILE_PATH_LITERAL("OfflinePages.db"))));
+  ASSERT_TRUE(connection.is_open());
+  ASSERT_TRUE(connection.BeginTransaction());
+  ASSERT_TRUE(connection.Execute("CREATE TABLE " OFFLINE_PAGES_TABLE_NAME
+                                 "(offline_id INTEGER PRIMARY KEY NOT NULL,"
+                                 " creation_time INTEGER NOT NULL,"
+                                 " file_size INTEGER NOT NULL,"
+                                 " version INTEGER NOT NULL,"
+                                 " last_access_time INTEGER NOT NULL,"
+                                 " access_count INTEGER NOT NULL,"
+                                 " status INTEGER NOT NULL DEFAULT 0,"
+                                 " user_initiated INTEGER,"
+                                 " client_namespace VARCHAR NOT NULL,"
+                                 " client_id VARCHAR NOT NULL,"
+                                 " online_url VARCHAR NOT NULL,"
+                                 " offline_url VARCHAR NOT NULL DEFAULT '',"
+                                 " file_path VARCHAR NOT NULL"
+                                 ")"));
+  ASSERT_TRUE(connection.CommitTransaction());
+  ASSERT_TRUE(connection.DoesTableExist(OFFLINE_PAGES_TABLE_NAME));
+  ASSERT_FALSE(
+      connection.DoesColumnExist(OFFLINE_PAGES_TABLE_NAME, "expiration_time"));
+}
+
 class OfflinePageMetadataStoreFactory {
  public:
   virtual OfflinePageMetadataStore* BuildStore(const base::FilePath& file) = 0;
+  virtual OfflinePageMetadataStore* BuildBadStore(

[fgorski, 2016/06/03 18:17:16]

Can we call it: BuildV1Store() or something indicating that it was valid at some
point but is no longer?

Actually it seems that you are doing the upgrade in this method. How about:
BuildStoreWithUpgrade()

[romax, 2016/06/03 19:36:22]

Done.

+      const base::FilePath& file) = 0;
 };
 
 class OfflinePageMetadataStoreSQLFactory
     : public OfflinePageMetadataStoreFactory {
  public:
   OfflinePageMetadataStore* BuildStore(const base::FilePath& file) override {
     OfflinePageMetadataStoreSQL* store = new OfflinePageMetadataStoreSQL(
         base::ThreadTaskRunnerHandle::Get(), file);
     return store;
   }
+
+  OfflinePageMetadataStore* BuildBadStore(const base::FilePath& file) override {
+    BuildBadTable(file);
+    OfflinePageMetadataStoreSQL* store = new OfflinePageMetadataStoreSQL(
+        base::ThreadTaskRunnerHandle::Get(), file);
+    return store;
+  }
 };
 
 enum CalledCallback { NONE, LOAD, ADD, REMOVE, DESTROY };
 enum Status { STATUS_NONE, STATUS_TRUE, STATUS_FALSE };
 
 class OfflinePageMetadataStoreTestBase : public testing::Test {
  public:
   OfflinePageMetadataStoreTestBase();
   ~OfflinePageMetadataStoreTestBase() override;
 
@@ skipping 54 matching lines @@
 void OfflinePageMetadataStoreTestBase::ClearResults() {
   last_called_callback_ = NONE;
   last_status_ = STATUS_NONE;
   offline_pages_.clear();
 }
 
 template <typename T>
 class OfflinePageMetadataStoreTest : public OfflinePageMetadataStoreTestBase {
  public:
   std::unique_ptr<OfflinePageMetadataStore> BuildStore();
+  std::unique_ptr<OfflinePageMetadataStore> BuildBadStore();
 
  protected:
   T factory_;
 };
 
 template <typename T>
 std::unique_ptr<OfflinePageMetadataStore>
 OfflinePageMetadataStoreTest<T>::BuildStore() {
   std::unique_ptr<OfflinePageMetadataStore> store(
       factory_.BuildStore(temp_directory_.path()));
   store->Load(base::Bind(&OfflinePageMetadataStoreTestBase::LoadCallback,
                          base::Unretained(this)));
   PumpLoop();
   return store;
 }
 
+template <typename T>
+std::unique_ptr<OfflinePageMetadataStore>
+OfflinePageMetadataStoreTest<T>::BuildBadStore() {
+  std::unique_ptr<OfflinePageMetadataStore> store(
+      factory_.BuildBadStore(temp_directory_.path()));
+  store->Load(base::Bind(&OfflinePageMetadataStoreTestBase::LoadCallback,
+                         base::Unretained(this)));
+  PumpLoop();
+  return store;
+}
+
 typedef testing::Types<OfflinePageMetadataStoreSQLFactory> MyTypes;
 TYPED_TEST_CASE(OfflinePageMetadataStoreTest, MyTypes);
 
 // Loads empty store and makes sure that there are no offline pages stored in
 // it.
 TYPED_TEST(OfflinePageMetadataStoreTest, LoadEmptyStore) {
   std::unique_ptr<OfflinePageMetadataStore> store(this->BuildStore());
   EXPECT_EQ(LOAD, this->last_called_callback_);
   EXPECT_EQ(STATUS_TRUE, this->last_status_);
   EXPECT_EQ(0U, this->offline_pages_.size());
 }
 
+// Loads a store which has an outdated schema.
+// This test case would crash if it's not handling correctly when we're loading
+// old version stores.
+// TODO(romax): Move this to sql_unittest.
+TYPED_TEST(OfflinePageMetadataStoreTest, LoadExistingBadStore) {
+  std::unique_ptr<OfflinePageMetadataStore> store(this->BuildBadStore());

[fgorski, 2016/06/03 18:17:16]

can you omit this->?

[romax, 2016/06/03 19:36:22]

no, since TYPED_TEST is a derived template class so accessing member should use
this-> explicitly.

[fgorski, 2016/06/03 20:04:17]

Acknowledged. Thanks for checking.

+  EXPECT_EQ(LOAD, this->last_called_callback_);
+  EXPECT_EQ(STATUS_TRUE, this->last_status_);
+  EXPECT_EQ(0U, this->offline_pages_.size());
+  OfflinePageItem offline_page(GURL(kTestURL), 1234LL, kTestClientId1,
+                               base::FilePath(kFilePath), kFileSize);
+  store->AddOrUpdateOfflinePage(
+      offline_page,
+      base::Bind(&OfflinePageMetadataStoreTestBase::UpdateCallback,
+                 base::Unretained(this), ADD));
+  this->PumpLoop();
+  EXPECT_EQ(ADD, this->last_called_callback_);
+  EXPECT_EQ(STATUS_TRUE, this->last_status_);
+}
+
 // Adds metadata of an offline page into a store and then opens the store
 // again to make sure that stored metadata survives store restarts.
 TYPED_TEST(OfflinePageMetadataStoreTest, AddOfflinePage) {
   std::unique_ptr<OfflinePageMetadataStore> store(this->BuildStore());
   OfflinePageItem offline_page(GURL(kTestURL), 1234LL, kTestClientId1,
                                base::FilePath(kFilePath), kFileSize);
   store->AddOrUpdateOfflinePage(
       offline_page,
       base::Bind(&OfflinePageMetadataStoreTestBase::UpdateCallback,
                  base::Unretained(this), ADD));
@@ skipping 226 matching lines @@
   EXPECT_EQ(offline_page.last_access_time,
             this->offline_pages_[0].last_access_time);
   EXPECT_EQ(offline_page.expiration_time,
             this->offline_pages_[0].expiration_time);
   EXPECT_EQ(offline_page.access_count, this->offline_pages_[0].access_count);
   EXPECT_EQ(offline_page.client_id, this->offline_pages_[0].client_id);
 }
 
 }  // namespace
 }  // namespace offline_pages