Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2019333006: Replace void* with CFXJSE_HostObect and make wrapped objects inherit from it (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace void* with CFXJSE_HostObect and make wrapped objects inherit from it This will avoid a re-occurrence of BUG 613607 should someone again optimize away CXFA_Object's virtual dtor. Committed: https://pdfium.googlesource.com/pdfium/+/29adee77d4a7566bc6832cc825198c0571426163

Patch Set 1 #

Patch Set 2 : static casts #

Patch Set 3 : Even more static_cast #

Patch Set 4 : Rebase past Dan's work. #

Patch Set 5 : Blown merge #

Patch Set 6 : Another blown merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -155 lines) Patch
M xfa/fxfa/app/xfa_ffdochandler.cpp View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 2 3 4 108 chunks +108 lines, -108 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 2 3 4 5 9 chunks +15 lines, -14 lines 0 comments Download
M xfa/fxjse/context.h View 2 chunks +5 lines, -4 lines 0 comments Download
M xfa/fxjse/context.cpp View 1 2 3 3 chunks +14 lines, -11 lines 0 comments Download
M xfa/fxjse/include/fxjse.h View 1 2 3 4 chunks +6 lines, -3 lines 0 comments Download
M xfa/fxjse/value.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxjse/value.cpp View 1 2 3 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Tom Sepez
Lei, for review. Dan, let me know when your patches have landed so I can ...
4 years, 6 months ago (2016-05-31 19:07:08 UTC) #3
dsinclair
lgtm. my patches have landed.
4 years, 6 months ago (2016-05-31 19:13:34 UTC) #4
Tom Sepez
On 2016/05/31 19:13:34, dsinclair wrote: > lgtm. > > my patches have landed. Ok, Lei?
4 years, 6 months ago (2016-05-31 21:14:19 UTC) #5
Lei Zhang
lgtm
4 years, 6 months ago (2016-05-31 21:20:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019333006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019333006/100001
4 years, 6 months ago (2016-05-31 21:21:53 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 21:22:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/29adee77d4a7566bc6832cc825198c057142...

Powered by Google App Engine
This is Rietveld 408576698