Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2019333004: Revert of Plumb decoded video pixel format from GPU process to renderer. (Closed)

Created:
4 years, 6 months ago by Pawel Osciak
Modified:
4 years, 6 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Plumb decoded video pixel format from GPU process to renderer. (patchset #12 id:210001 of https://codereview.chromium.org/1942123002/ ) Reason for revert: Causing CrOS PFQs to fail due to crbug.com/615993. Original issue's description: > Plumb decoded video pixel format from GPU process to renderer. > > This allows the renderer to correctly interpret NV12 and other pixel formats. > > BUG=574292 > > Committed: https://crrev.com/1ace3b00d9dad163255b8e73deaad53c0a43a79a > Cr-Commit-Position: refs/heads/master@{#396634} TBR=miu@chromium.org,sandersd@chromium.org,liberato@chromium.org,nasko@chromium.org,jbauman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=574292 Committed: https://crrev.com/f22b1b6d4d903ba1640c942c70cd6e95ff8a03f5 Cr-Commit-Position: refs/heads/master@{#396812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -116 lines) Patch
M chrome/gpu/arc_gpu_video_decode_accelerator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/gpu/arc_gpu_video_decode_accelerator.cc View 2 chunks +1 line, -7 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 4 chunks +5 lines, -14 lines 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/ppb_video_decoder_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/ppb_video_decoder_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/gpu_video_decoder.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 5 chunks +7 lines, -16 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/android_video_decode_accelerator_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/gpu/fake_video_decode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_decode_accelerator_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/gpu/ipc/common/media_messages.h View 1 chunk +5 lines, -6 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M media/gpu/v4l2_video_decode_accelerator.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/v4l2_video_decode_accelerator.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M media/gpu/vaapi_video_decode_accelerator.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/vaapi_video_decode_accelerator.cc View 3 chunks +19 lines, -17 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 6 chunks +3 lines, -10 lines 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/video/video_decode_accelerator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/video/video_decode_accelerator.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Pawel Osciak
Created Revert of Plumb decoded video pixel format from GPU process to renderer.
4 years, 6 months ago (2016-05-31 09:23:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019333004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019333004/1
4 years, 6 months ago (2016-05-31 09:23:30 UTC) #3
Daniel Kurtz
On 2016/05/31 09:23:30, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 6 months ago (2016-05-31 09:56:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 10:56:58 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 10:58:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f22b1b6d4d903ba1640c942c70cd6e95ff8a03f5
Cr-Commit-Position: refs/heads/master@{#396812}

Powered by Google App Engine
This is Rietveld 408576698