Issue 201933003: Merge 256851 "Adds a hide button to the desktop capture notifica..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201933003: Merge 256851 "Adds a hide button to the desktop capture notifica..." (Closed)

Created:
6 years, 9 months ago by jiayl

Modified:
6 years, 9 months ago

Reviewers:
jiayl

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/branches/1847/src/

Visibility:
Public.

Merge 256851 "Adds a hide button to the desktop capture notifica..." > Adds a hide button to the desktop capture notification bar. > The new button is used to minimize the notification to the taskbar (or Mac Dock). It's designed to look like a link to differentiate itself from the "stop sharing" button, which is an action on desktop capture. > > BUG=316731 > > Review URL: https://codereview.chromium.org/195283003 TBR=jiayl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257442

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -21 lines)			Patch
M	chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.mm	View	5 chunks	+27 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa_unittest.mm	View	3 chunks	+21 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/screen_capture_notification_ui_views.cc	View	9 chunks	+56 lines, -14 lines	0 comments	Download

Total messages: 2 (0 generated)

jiayl

6 years, 9 months ago (2014-03-17 16:25:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r257442 (tree was closed).