Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2019273002: Make reallocation of large objects reliable. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make reallocation of large objects reliable. If ThreadHeap::reallocate<T>() is called with a size that's equal or greater to the large object threshold (64k, currently), make sure it ends up being allocated as a large object. Large objects would previously be attempted allocated on a normal arena, hoping that the allocation couldn't be serviced by bump allocation, but fall into an out-of-line allocation. R= BUG= Committed: https://crrev.com/576ad2e3f18450ea084d9ba0ad662f5e321f262b Cr-Commit-Position: refs/heads/master@{#396712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +19 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 2 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. Going over crbug.com/581698 details one more time..don't think this will make ...
4 years, 6 months ago (2016-05-30 08:58:40 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-05-30 10:37:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019273002/1
4 years, 6 months ago (2016-05-30 10:38:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 11:37:25 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 11:38:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/576ad2e3f18450ea084d9ba0ad662f5e321f262b
Cr-Commit-Position: refs/heads/master@{#396712}

Powered by Google App Engine
This is Rietveld 408576698