Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2019243002: Extract analyze-baselines command out of rebaseline.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index 49aea6ef8ac224de882586a188db4625fe3a4d6b..98145acb63183eb05d0df12b3cab6f468747adc6 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -278,46 +278,6 @@ class OptimizeBaselines(AbstractRebaseliningCommand):
print json.dumps(self._scm_changes)
-class AnalyzeBaselines(AbstractRebaseliningCommand):
- name = "analyze-baselines"
- help_text = "Analyzes the baselines for the given tests and prints results that are identical."
- show_in_main_help = True
- argument_names = "TEST_NAMES"
-
- def __init__(self):
- super(AnalyzeBaselines, self).__init__(options=[
- self.suffixes_option,
- optparse.make_option('--missing', action='store_true', default=False, help='Show missing baselines as well.'),
- ] + self.platform_options)
- self._optimizer_class = BaselineOptimizer # overridable for testing
- self._baseline_optimizer = None
- self._port = None
-
- def _write(self, msg):
- print msg
-
- def _analyze_baseline(self, options, test_name):
- for suffix in self._baseline_suffix_list:
- baseline_name = _baseline_name(self._tool.filesystem, test_name, suffix)
- results_by_directory = self._baseline_optimizer.read_results_by_directory(baseline_name)
- if results_by_directory:
- self._write("%s:" % baseline_name)
- self._baseline_optimizer.write_by_directory(results_by_directory, self._write, " ")
- elif options.missing:
- self._write("%s: (no baselines found)" % baseline_name)
-
- def execute(self, options, args, tool):
- self._baseline_suffix_list = options.suffixes.split(',')
- port_names = tool.port_factory.all_port_names(options.platform)
- if not port_names:
- print "No port names match '%s'" % options.platform
- return
- self._port = tool.port_factory.get(port_names[0])
- self._baseline_optimizer = self._optimizer_class(tool, self._port, port_names, skip_scm_commands=False)
- for test_name in self._port.tests(args):
- self._analyze_baseline(options, test_name)
-
-
class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
"""Base class for rebaseline commands that do some tasks in parallel."""
# Not overriding execute() - pylint: disable=abstract-method

Powered by Google App Engine
This is Rietveld 408576698