MacViews: Fix crash caused due to nil TextInputClient.

ui/views/cocoa/bridged_native_widget_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_native_widget.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 
@@ skipping 92 matching lines @@
   gfx::Rect right_caret = GetCaretBoundsForPosition(
       client, composition_text, query_range.location + query_range.length,
       nullptr);
 
   // The expected bounds correspond to the area between the left and right caret
   // positions.
   return gfx::Rect(left_caret.x(), left_caret.y(),
                    right_caret.x() - left_caret.x(), left_caret.height());
 }
 
+// Implemented NSResponder action messages for use in tests.

[tapted, 2016/05/31 01:49:14]

nit: constants should come before functions in each section, so this should
probably go to the top of the anonymous namespace.

[karandeepb, 2016/05/31 01:57:33]

Done.

+NSArray* kMoveActions = @[

[tapted, 2016/05/31 01:49:14]

nit: NSArray* const kMoveActions - same below (it's OK to have `const` on the
variable itself, we just wouldn't use `const NSArray*` or [equivalent] `NSArray
const*` for ObjectiveC types since that would be asking the NSArray to be const
which is weird).

[karandeepb, 2016/05/31 01:57:33]

Done.

+  @"moveForward:",
+  @"moveRight:",
+  @"moveBackward:",
+  @"moveLeft:",
+  @"moveUp:",
+  @"moveDown:",
+  @"moveWordForward:",
+  @"moveWordBackward:",
+  @"moveToBeginningOfLine:",
+  @"moveToEndOfLine:",
+  @"moveToBeginningOfParagraph:",
+  @"moveToEndOfParagraph:",
+  @"moveToEndOfDocument:",
+  @"moveToBeginningOfDocument:",
+  @"pageDown:",
+  @"pageUp:",
+  @"moveWordRight:",
+  @"moveWordLeft:",
+  @"moveToLeftEndOfLine:",
+  @"moveToRightEndOfLine:"
+];
+
+NSArray* kSelectActions = @[
+  @"moveBackwardAndModifySelection:",
+  @"moveForwardAndModifySelection:",
+  @"moveWordForwardAndModifySelection:",
+  @"moveWordBackwardAndModifySelection:",
+  @"moveUpAndModifySelection:",
+  @"moveDownAndModifySelection:",
+  @"moveToBeginningOfLineAndModifySelection:",
+  @"moveToEndOfLineAndModifySelection:",
+  @"moveToBeginningOfParagraphAndModifySelection:",
+  @"moveToEndOfParagraphAndModifySelection:",
+  @"moveToEndOfDocumentAndModifySelection:",
+  @"moveToBeginningOfDocumentAndModifySelection:",
+  @"pageDownAndModifySelection:",
+  @"pageUpAndModifySelection:",
+  @"moveParagraphForwardAndModifySelection:",
+  @"moveParagraphBackwardAndModifySelection:",
+  @"moveRightAndModifySelection:",
+  @"moveLeftAndModifySelection:",
+  @"moveWordRightAndModifySelection:",
+  @"moveWordLeftAndModifySelection:",
+  @"moveToLeftEndOfLineAndModifySelection:",
+  @"moveToRightEndOfLineAndModifySelection:"
+];
+
+NSArray* kDeleteActions = @[
+  @"deleteForward:", @"deleteBackward:", @"deleteWordForward:",
+  @"deleteWordBackward:", @"deleteToBeginningOfLine:", @"deleteToEndOfLine:",
+  @"deleteToBeginningOfParagraph:", @"deleteToEndOfParagraph:"
+];
+
+NSArray* kMiscActions = @[ @"insertText:", @"cancelOperation:" ];
+
 }  // namespace
 
 // Class to override -[NSWindow toggleFullScreen:] to a no-op. This simulates
 // NSWindow's behavior when attempting to toggle fullscreen state again, when
 // the last attempt failed but Cocoa has not yet sent
 // windowDidFailToEnterFullScreen:.
 @interface BridgedNativeWidgetTestFullScreenWindow : NativeWidgetMacNSWindow {
  @private
   int ignoredToggleFullScreenCount_;
 }
@@ skipping 814 matching lines @@
 TEST_F(BridgedNativeWidgetTest, TextInput_DeleteToBeginningOfParagraph) {
   TestDeleteBeginning(@selector(deleteToBeginningOfParagraph:));
 }
 
 TEST_F(BridgedNativeWidgetTest, TextInput_DeleteToEndOfParagraph) {
   TestDeleteEnd(@selector(deleteToEndOfParagraph:));
 }
 
 // Test move commands against expectations set by |dummy_text_view_|.
 TEST_F(BridgedNativeWidgetTest, TextInput_MoveEditingCommands) {
-  NSArray* selectors = @[
-    @"moveForward:",
-    @"moveRight:",
-    @"moveBackward:",
-    @"moveLeft:",
-    @"moveUp:",
-    @"moveDown:",
-    @"moveWordForward:",
-    @"moveWordBackward:",
-    @"moveToBeginningOfLine:",
-    @"moveToEndOfLine:",
-    @"moveToBeginningOfParagraph:",
-    @"moveToEndOfParagraph:",
-    @"moveToEndOfDocument:",
-    @"moveToBeginningOfDocument:",
-    @"pageDown:",
-    @"pageUp:",
-    @"moveWordRight:",
-    @"moveWordLeft:",
-    @"moveToLeftEndOfLine:",
-    @"moveToRightEndOfLine:"
-  ];
-  TestEditingCommands(selectors);
+  TestEditingCommands(kMoveActions);
 }
 
 // Todo(karandeepb): Enable this test once the behavior of all move and select
 // commands are fixed.
 // Test move and select commands against expectations set by |dummy_text_view_|.
 TEST_F(BridgedNativeWidgetTest,
        TextInput_MoveAndSelectEditingCommands_DISABLED) {
-  NSArray* selectors = @[
-    @"moveBackwardAndModifySelection:",
-    @"moveForwardAndModifySelection:",
-    @"moveWordForwardAndModifySelection:",
-    @"moveWordBackwardAndModifySelection:",
-    @"moveUpAndModifySelection:",
-    @"moveDownAndModifySelection:",
-    @"moveToBeginningOfLineAndModifySelection:",
-    @"moveToEndOfLineAndModifySelection:",
-    @"moveToBeginningOfParagraphAndModifySelection:",
-    @"moveToEndOfParagraphAndModifySelection:",
-    @"moveToEndOfDocumentAndModifySelection:",
-    @"moveToBeginningOfDocumentAndModifySelection:",
-    @"pageDownAndModifySelection:",
-    @"pageUpAndModifySelection:",
-    @"moveParagraphForwardAndModifySelection:",
-    @"moveParagraphBackwardAndModifySelection:",
-    @"moveRightAndModifySelection:",
-    @"moveLeftAndModifySelection:",
-    @"moveWordRightAndModifySelection:",
-    @"moveWordLeftAndModifySelection:",
-    @"moveToLeftEndOfLineAndModifySelection:",
-    @"moveToRightEndOfLineAndModifySelection:"
-  ];
-  TestEditingCommands(selectors);
+  TestEditingCommands(kSelectActions);
 }
 
 // Test delete commands against expectations set by |dummy_text_view_|.
 TEST_F(BridgedNativeWidgetTest, TextInput_DeleteCommands) {
-  NSArray* selectors = @[
-    @"deleteForward:", @"deleteBackward:", @"deleteWordForward:",
-    @"deleteWordBackward:", @"deleteToBeginningOfLine:", @"deleteToEndOfLine:",
-    @"deleteToBeginningOfParagraph:", @"deleteToEndOfParagraph:"
-  ];
-  TestEditingCommands(selectors);
+  TestEditingCommands(kDeleteActions);
+}
+
+// Test that we don't crash during an action message even if the TextInputClient
+// is nil. Regression test for crbug.com/615745.
+TEST_F(BridgedNativeWidgetTest, NilTextInputClient) {
+  [ns_view_ setTextInputClient:nil];
+  NSMutableArray* selectors = [NSMutableArray array];
+  [selectors addObjectsFromArray:kMoveActions];
+  [selectors addObjectsFromArray:kSelectActions];
+  [selectors addObjectsFromArray:kDeleteActions];
+  [selectors addObjectsFromArray:kMiscActions];
+
+  for (NSString* selector in selectors)
+    [ns_view_ doCommandBySelector:NSSelectorFromString(selector)];
 }
 
 // Test firstRectForCharacterRange:actualRange for cases where query range is
 // empty or outside composition range.
 TEST_F(BridgedNativeWidgetTest, TextInput_FirstRectForCharacterRange_Caret) {
   InstallTextField("");
   ui::TextInputClient* client = [ns_view_ textInputClient];
 
   // No composition. Ensure bounds and range corresponding to the current caret
   // position are returned.
@@ skipping 146 matching lines @@
   [center postNotificationName:NSWindowDidExitFullScreenNotification
                         object:window];
   EXPECT_EQ(1, [window ignoredToggleFullScreenCount]);  // No change.
   EXPECT_FALSE(bridge()->target_fullscreen_state());
 
   widget_->CloseNow();
 }
 
 }  // namespace test
 }  // namespace views