MacViews: Fix crash caused due to nil TextInputClient.

ui/views/cocoa/bridged_native_widget_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_native_widget.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 
@@ skipping 993 matching lines @@
 // Test delete commands against expectations set by |dummy_text_view_|.
 TEST_F(BridgedNativeWidgetTest, TextInput_DeleteCommands) {
   NSArray* selectors = @[
     @"deleteForward:", @"deleteBackward:", @"deleteWordForward:",
     @"deleteWordBackward:", @"deleteToBeginningOfLine:", @"deleteToEndOfLine:",
     @"deleteToBeginningOfParagraph:", @"deleteToEndOfParagraph:"
   ];
   TestEditingCommands(selectors);
 }
 
+// Test that we don't crash during an action message even if the TextInputClient
+// is nil. Regression test for crbug.com/615745.
+TEST_F(BridgedNativeWidgetTest, NilTextInputClient) {
+  [ns_view_ setTextInputClient:nil];
+  NSArray* selectors = @[

[tapted, 2016/05/31 01:17:10]

We shouldn't repeat these - can we do something like

NSArray* selectors = @[ @"insertText:" ];
selectors = [selectors arrayByAddingObjectsFromArray:kMoveActions];
selectors = [selectors arrayByAddingObjectsFromArray:kSelectActions];
selectors = [selectors arrayByAddingObjectsFromArray:kDeleteActions];

[karandeepb, 2016/05/31 01:42:33]

Done.

+    @"insertText:",
+    @"moveForward:",
+    @"moveRight:",
+    @"moveBackward:",
+    @"moveLeft:",
+    @"moveUp:",
+    @"moveDown:",
+    @"moveWordForward:",
+    @"moveWordBackward:",
+    @"moveToBeginningOfLine:",
+    @"moveToEndOfLine:",
+    @"moveToBeginningOfParagraph:",
+    @"moveToEndOfParagraph:",
+    @"moveToEndOfDocument:",
+    @"moveToBeginningOfDocument:",
+    @"pageDown:",
+    @"pageUp:",
+    @"moveBackwardAndModifySelection:",
+    @"moveForwardAndModifySelection:",
+    @"moveWordForwardAndModifySelection:",
+    @"moveWordBackwardAndModifySelection:",
+    @"moveUpAndModifySelection:",
+    @"moveDownAndModifySelection:",
+    @"moveToBeginningOfLineAndModifySelection:",
+    @"moveToEndOfLineAndModifySelection:",
+    @"moveToBeginningOfParagraphAndModifySelection:",
+    @"moveToEndOfParagraphAndModifySelection:",
+    @"moveToEndOfDocumentAndModifySelection:",
+    @"moveToBeginningOfDocumentAndModifySelection:",
+    @"pageDownAndModifySelection:",
+    @"pageUpAndModifySelection:",
+    @"moveParagraphForwardAndModifySelection:",
+    @"moveParagraphBackwardAndModifySelection:",
+    @"moveWordRight:",
+    @"moveWordLeft:",
+    @"moveRightAndModifySelection:",
+    @"moveLeftAndModifySelection:",
+    @"moveWordRightAndModifySelection:",
+    @"moveWordLeftAndModifySelection:",
+    @"moveToLeftEndOfLine:",
+    @"moveToRightEndOfLine:",
+    @"moveToLeftEndOfLineAndModifySelection:",
+    @"moveToRightEndOfLineAndModifySelection:",
+    @"deleteForward:",
+    @"deleteBackward:",
+    @"deleteWordForward:",
+    @"deleteWordBackward:",
+    @"deleteToBeginningOfLine:",
+    @"deleteToEndOfLine:",
+    @"deleteToBeginningOfParagraph:",
+    @"deleteToEndOfParagraph:",
+    @"cancelOperation:"
+  ];
+  for (NSString* selector in selectors) {
+    SEL sel = NSSelectorFromString(selector);
+    [ns_view_ doCommandBySelector:sel];
+  }
+}
+
 // Test firstRectForCharacterRange:actualRange for cases where query range is
 // empty or outside composition range.
 TEST_F(BridgedNativeWidgetTest, TextInput_FirstRectForCharacterRange_Caret) {
   InstallTextField("");
   ui::TextInputClient* client = [ns_view_ textInputClient];
 
   // No composition. Ensure bounds and range corresponding to the current caret
   // position are returned.
   // Initially selection range will be [0, 0].
   NSRange caret_range = NSMakeRange(0, 0);
@@ skipping 144 matching lines @@
   [center postNotificationName:NSWindowDidExitFullScreenNotification
                         object:window];
   EXPECT_EQ(1, [window ignoredToggleFullScreenCount]);  // No change.
   EXPECT_FALSE(bridge()->target_fullscreen_state());
 
   widget_->CloseNow();
 }
 
 }  // namespace test
 }  // namespace views