MacViews: Fix crash caused due to nil TextInputClient.

ui/views/cocoa/bridged_content_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_content_view.h"
 
 #include "base/logging.h"
 #import "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 61 matching lines @@
   if (menuController && menuController->owner() == widget) {
     if (menuController->OnWillDispatchKeyEvent(0, key_code) ==
         ui::POST_DISPATCH_NONE)
       return true;
   }
   return false;
 }
 
 // Returns true if |client| has RTL text.
 bool IsTextRTL(const ui::TextInputClient* client) {
+  DCHECK(client);

[tapted, 2016/05/30 10:31:54]

I think it's nicer for this just to return false, then rely on the checks in
handleAction:

We then just need to ensure there is some appropriate test coverage to ensure we
don't regress.

   gfx::Range text_range;
   base::string16 text;
   return client->GetTextRange(&text_range) &&
          client->GetTextFromRange(text_range, &text) &&
          base::i18n::GetStringDirection(text) == base::i18n::RIGHT_TO_LEFT;
 }
 
 // Returns the boundary rectangle for composition characters in the
 // |requested_range|. Sets |actual_range| corresponding to the returned
 // rectangle. For cases, where there is no composition text or the
@@ skipping 551 matching lines @@
 // direct insertText: through doCommandBySelector:, so this is still needed to
 // handle the case when inputContext: is nil. When inputContext: returns non-nil
 // text goes directly to insertText:replacementRange:.
 - (void)insertText:(id)text {
   [self insertText:text replacementRange:NSMakeRange(NSNotFound, 0)];
 }
 
 // Selection movement and scrolling.
 
 - (void)moveForward:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveLeft:sender]
                               : [self moveRight:sender];
 }
 
 - (void)moveRight:(id)sender {
   [self handleAction:IDS_MOVE_RIGHT
              keyCode:ui::VKEY_RIGHT
              domCode:ui::DomCode::ARROW_RIGHT
           eventFlags:0];
 }
 
 - (void)moveBackward:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveRight:sender]
                               : [self moveLeft:sender];
 }
 
 - (void)moveLeft:(id)sender {
   [self handleAction:IDS_MOVE_LEFT
              keyCode:ui::VKEY_LEFT
              domCode:ui::DomCode::ARROW_LEFT
           eventFlags:0];
 }
 
 - (void)moveUp:(id)sender {
   [self handleAction:IDS_MOVE_TO_BEGINNING_OF_LINE
              keyCode:ui::VKEY_UP
              domCode:ui::DomCode::ARROW_UP
           eventFlags:0];
 }
 
 - (void)moveDown:(id)sender {
   [self handleAction:IDS_MOVE_TO_END_OF_LINE
              keyCode:ui::VKEY_DOWN
              domCode:ui::DomCode::ARROW_DOWN
           eventFlags:0];
 }
 
 - (void)moveWordForward:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveWordLeft:sender]
                               : [self moveWordRight:sender];
 }
 
 - (void)moveWordBackward:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveWordRight:sender]
                               : [self moveWordLeft:sender];
 }
 
 - (void)moveToBeginningOfLine:(id)sender {
   [self handleAction:IDS_MOVE_TO_BEGINNING_OF_LINE
              keyCode:ui::VKEY_HOME
              domCode:ui::DomCode::HOME
           eventFlags:0];
 }
@@ skipping 35 matching lines @@
 }
 
 - (void)pageUp:(id)sender {
   [self handleAction:IDS_MOVE_TO_BEGINNING_OF_LINE
              keyCode:ui::VKEY_PRIOR
              domCode:ui::DomCode::PAGE_UP
           eventFlags:0];
 }
 
 - (void)moveBackwardAndModifySelection:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveRightAndModifySelection:sender]
                               : [self moveLeftAndModifySelection:sender];
 }
 
 - (void)moveForwardAndModifySelection:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveLeftAndModifySelection:sender]
                               : [self moveRightAndModifySelection:sender];
 }
 
 - (void)moveWordForwardAndModifySelection:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveWordLeftAndModifySelection:sender]
                               : [self moveWordRightAndModifySelection:sender];
 }
 
 - (void)moveWordBackwardAndModifySelection:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveWordRightAndModifySelection:sender]
                               : [self moveWordLeftAndModifySelection:sender];
 }
 
 - (void)moveUpAndModifySelection:(id)sender {
   [self handleAction:IDS_MOVE_TO_BEGINNING_OF_LINE_AND_MODIFY_SELECTION
              keyCode:ui::VKEY_UP
              domCode:ui::DomCode::ARROW_UP
           eventFlags:ui::EF_SHIFT_DOWN];
 }
@@ skipping 105 matching lines @@
 }
 
 - (void)moveWordLeftAndModifySelection:(id)sender {
   [self handleAction:IDS_MOVE_WORD_LEFT_AND_MODIFY_SELECTION
              keyCode:ui::VKEY_LEFT
              domCode:ui::DomCode::ARROW_LEFT
           eventFlags:ui::EF_CONTROL_DOWN | ui::EF_SHIFT_DOWN];
 }
 
 - (void)moveToLeftEndOfLine:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveToEndOfLine:sender]
                               : [self moveToBeginningOfLine:sender];
 }
 
 - (void)moveToRightEndOfLine:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_) ? [self moveToBeginningOfLine:sender]
                               : [self moveToEndOfLine:sender];
 }
 
 - (void)moveToLeftEndOfLineAndModifySelection:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_)
       ? [self moveToEndOfLineAndModifySelection:sender]
       : [self moveToBeginningOfLineAndModifySelection:sender];
 }
 
 - (void)moveToRightEndOfLineAndModifySelection:(id)sender {
+  if (!textInputClient_)
+    return;
   IsTextRTL(textInputClient_)
       ? [self moveToBeginningOfLineAndModifySelection:sender]
       : [self moveToEndOfLineAndModifySelection:sender];
 }
 
 // Deletions.
 
 - (void)deleteForward:(id)sender {
   [self handleAction:IDS_DELETE_FORWARD
              keyCode:ui::VKEY_DELETE
@@ skipping 268 matching lines @@
   }
 
   return [super accessibilityAttributeValue:attribute];
 }
 
 - (id)accessibilityHitTest:(NSPoint)point {
   return [hostedView_->GetNativeViewAccessible() accessibilityHitTest:point];
 }
 
 @end