Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2019223003: Tune down debugging emergency for clearAnimatedType() a notch (Closed)

Created:
4 years, 6 months ago by davve
Modified:
4 years, 6 months ago
Reviewers:
haraken, sigbjorn
CC:
chromium-reviews, Eric Willigers, krit, rjwright, blink-reviews-animation_chromium.org, kouhei+svg_chromium.org, fs, shans, f(malita), darktears, blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tune down debugging emergency for clearAnimatedType() a notch Fixing re-entrancy into the animation code through the garbage collector is proving to be a non-trivial task. Since we now know more about the issue, downgrade the RELEASE_ASSERT to a DCHECK to not affect more users than necessary while getting this bug sorted out. BUG=613709 Committed: https://crrev.com/65dd95ea2016653f303fa75cc7736a8c633b7a96 Cr-Commit-Position: refs/heads/master@{#396705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019223003/1
4 years, 6 months ago (2016-05-30 07:39:49 UTC) #2
davve
Something for the meantime?
4 years, 6 months ago (2016-05-30 07:40:52 UTC) #4
haraken
\KGTN
4 years, 6 months ago (2016-05-30 07:41:42 UTC) #5
haraken
LGTM
4 years, 6 months ago (2016-05-30 07:41:51 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-30 09:23:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019223003/1
4 years, 6 months ago (2016-05-30 09:41:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 09:44:44 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 09:46:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65dd95ea2016653f303fa75cc7736a8c633b7a96
Cr-Commit-Position: refs/heads/master@{#396705}

Powered by Google App Engine
This is Rietveld 408576698